Re: [ovs-dev] [minor fixes 5/6] bridge: Fix VLAN selection mirroring logic.

2011-04-18 Thread Ethan Jackson
Wow. That's a bit scary. Looks Good. Ethan On Mon, Apr 11, 2011 at 11:02 AM, Ben Pfaff wrote: > The logic here did not make sense.  A packet arriving on a port is mirrored > if the port is a mirroring source port AND (not OR) the packet is in one of > the VLANs that is mirrored. > > This test

[ovs-dev] [minor fixes 5/6] bridge: Fix VLAN selection mirroring logic.

2011-04-11 Thread Ben Pfaff
The logic here did not make sense. A packet arriving on a port is mirrored if the port is a mirroring source port AND (not OR) the packet is in one of the VLANs that is mirrored. This test has been here since the mirroring code was introduced. It seems to me that it was never correct. --- vswit