Re: [ovs-dev] [megaflow v4 1/2] datapath: Mega flow implementation

2013-06-14 Thread Jesse Gross
On Fri, Jun 14, 2013 at 8:43 AM, Andy Zhou wrote: > On Fri, Jun 14, 2013 at 7:38 AM, Jesse Gross wrote: >> On Thu, Jun 13, 2013 at 7:32 PM, Andy Zhou wrote: >> >> > + for (i = 0; i < size; i++) >> >> > + if (*(fp + i)) >> >> > + return false; >> >> >> >>

Re: [ovs-dev] [megaflow v4 1/2] datapath: Mega flow implementation

2013-06-14 Thread Andy Zhou
On Fri, Jun 14, 2013 at 7:38 AM, Jesse Gross wrote: > On Thu, Jun 13, 2013 at 7:32 PM, Andy Zhou wrote: > >> > static int parse_icmpv6(struct sk_buff *skb, struct sw_flow_key *key, > >> > - int *key_lenp, int nh_len) > >> > + int nh_len) > >> [...] >

Re: [ovs-dev] [megaflow v4 1/2] datapath: Mega flow implementation

2013-06-14 Thread Jesse Gross
On Thu, Jun 13, 2013 at 7:32 PM, Andy Zhou wrote: > Thanks for the review. A few comments inline: > >> > +static void flow_key_mask(struct sw_flow_key *dst, >> > + const struct sw_flow_key *src, >> > + const struct sw_flow_mask *mfm) >> > +{ >> > +

Re: [ovs-dev] [megaflow v4 1/2] datapath: Mega flow implementation

2013-06-13 Thread Andy Zhou
Thanks for the review. A few comments inline: > +static void flow_key_mask(struct sw_flow_key *dst, > > + const struct sw_flow_key *src, > > + const struct sw_flow_mask *mfm) > > +{ > > + u8 *m = (u8 *)&mfm->key + mfm->range.start; > > +

Re: [ovs-dev] [megaflow v4 1/2] datapath: Mega flow implementation

2013-06-12 Thread Jesse Gross
On Wed, Jun 12, 2013 at 10:00 AM, Andy Zhou wrote: > Add mega flow support in kernel datapath. > > Pravin has made significant contributions to this patch. Including > the mega flow id look up scheme, API clean ups, and bug fixes. > > Co-authored-by: Pravin B Shelar > Signed-off-by: Pravin B Shel