Re: [ovs-dev] [megaflow v3 1/2] datapath: Mega flow implementation

2013-06-12 Thread Andy Zhou
Sure, will send out v4 of the patch soon. On Wed, Jun 12, 2013 at 9:42 AM, Jesse Gross wrote: > On Tue, Jun 11, 2013 at 8:49 PM, Andy Zhou wrote: > > Did not realize that the __CHECK_ENDIAN__ flags has to be passed by hand > to > > enable those checks. This is what I use to verify the fix. A

Re: [ovs-dev] [megaflow v3 1/2] datapath: Mega flow implementation

2013-06-12 Thread Jesse Gross
On Tue, Jun 11, 2013 at 8:49 PM, Andy Zhou wrote: > Did not realize that the __CHECK_ENDIAN__ flags has to be passed by hand to > enable those checks. This is what I use to verify the fix. Any better way > to enable this check? > > make C=2 CF="-D__CHECK_ENDIAN__" That's how run it (actually I

Re: [ovs-dev] [megaflow v3 1/2] datapath: Mega flow implementation

2013-06-11 Thread Andy Zhou
Did not realize that the __CHECK_ENDIAN__ flags has to be passed by hand to enable those checks. This is what I use to verify the fix. Any better way to enable this check? make C=2 CF="-D__CHECK_ENDIAN__" The following incremental patch fixes those warnings. Andy diff --git a/datapath/flow.c

Re: [ovs-dev] [megaflow v3 1/2] datapath: Mega flow implementation

2013-06-11 Thread Jesse Gross
On Tue, Jun 11, 2013 at 4:45 PM, Andy Zhou wrote: > Add mega flow support in kernel datapath. > > Pravin has made significant contributions to this patch. Including > the mega flow id look up scheme, API clean ups, and bug fixes. > > Co-authored-by: Pravin B Shelar > Signed-off-by: Pravin B Shela