Re: [ovs-dev] [mask array v6 2/2] datapath: keep mask array compact when deleting mask

2014-06-19 Thread Andy Zhou
thanks, pushed both with the suggested fixes. On Wed, Jun 18, 2014 at 2:46 PM, Pravin Shelar wrote: > On Mon, Jun 16, 2014 at 1:18 PM, Andy Zhou wrote: >> When deleting a mask from the mask array, we always move the last entry >> into its current location. Another approach can be NULL in its >>

Re: [ovs-dev] [mask array v6 2/2] datapath: keep mask array compact when deleting mask

2014-06-18 Thread Pravin Shelar
On Mon, Jun 16, 2014 at 1:18 PM, Andy Zhou wrote: > When deleting a mask from the mask array, we always move the last entry > into its current location. Another approach can be NULL in its > current place, and periodically compact it. > > The approach taken by this patch is more efficient during r

[ovs-dev] [mask array v6 2/2] datapath: keep mask array compact when deleting mask

2014-06-16 Thread Andy Zhou
When deleting a mask from the mask array, we always move the last entry into its current location. Another approach can be NULL in its current place, and periodically compact it. The approach taken by this patch is more efficient during run time. During look up, fast path packet don't have to ski