Re: [ovs-dev] [link_resets 3/7] vswitchd: Remove iface_get_carrier().

2011-10-17 Thread Ben Pfaff
On Mon, Oct 17, 2011 at 01:15:00PM -0700, Ethan Jackson wrote: > On Mon, Oct 17, 2011 at 13:10, Ben Pfaff wrote: > > On Mon, Oct 17, 2011 at 12:10:20PM -0700, Ethan Jackson wrote: > >> It has only one caller, and doesn't improve the code's readability. > > > > Looks OK to me. ?Might be better with

Re: [ovs-dev] [link_resets 3/7] vswitchd: Remove iface_get_carrier().

2011-10-17 Thread Ethan Jackson
On Mon, Oct 17, 2011 at 13:10, Ben Pfaff wrote: > On Mon, Oct 17, 2011 at 12:10:20PM -0700, Ethan Jackson wrote: >> It has only one caller, and doesn't improve the code's readability. > > Looks OK to me.  Might be better with a variable instead of with lots > of line wrapping. One of the next pat

Re: [ovs-dev] [link_resets 3/7] vswitchd: Remove iface_get_carrier().

2011-10-17 Thread Ben Pfaff
On Mon, Oct 17, 2011 at 12:10:20PM -0700, Ethan Jackson wrote: > It has only one caller, and doesn't improve the code's readability. Looks OK to me. Might be better with a variable instead of with lots of line wrapping. ___ dev mailing list dev@openvswi

[ovs-dev] [link_resets 3/7] vswitchd: Remove iface_get_carrier().

2011-10-17 Thread Ethan Jackson
It has only one caller, and doesn't improve the code's readability. --- vswitchd/bridge.c | 16 +++- 1 files changed, 3 insertions(+), 13 deletions(-) diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index 186f250..d6a437f 100644 --- a/vswitchd/bridge.c +++ b/vswitchd/bridge.c @@