Re: [ovs-dev] [lacp_bugs 4/7] lacp: Require non-zero system ID.

2011-11-30 Thread Ben Pfaff
On Wed, Nov 30, 2011 at 01:51:24PM -0800, Ethan Jackson wrote: > Good catch, I missed this in testing because we typcially set a non-zero > sys_priority. > > I'll update the comments of the lacp_settings struct in a future patch. Sounds good, thank you. ___

Re: [ovs-dev] [lacp_bugs 4/7] lacp: Require non-zero system ID.

2011-11-30 Thread Ethan Jackson
Good catch, I missed this in testing because we typcially set a non-zero sys_priority. I'll update the comments of the lacp_settings struct in a future patch. Ethan --- lib/lacp.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/lib/lacp.c b/lib/lacp.c index 9e63bbb..6

Re: [ovs-dev] [lacp_bugs 4/7] lacp: Require non-zero system ID.

2011-11-29 Thread Ben Pfaff
On Tue, Nov 29, 2011 at 07:53:21PM -0800, Ethan Jackson wrote: > It's a bug if LACP is configured with a system ID of zero. This > patch assert fails in this case. Will the change to lacp_configure() have the desired effect? I think that the common case is that lacp_create() creates an all-zeros

[ovs-dev] [lacp_bugs 4/7] lacp: Require non-zero system ID.

2011-11-29 Thread Ethan Jackson
It's a bug if LACP is configured with a system ID of zero. This patch assert fails in this case. --- lib/lacp.c|1 + vswitchd/bridge.c |5 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/lib/lacp.c b/lib/lacp.c index 22cba94..9e63bbb 100644 --- a/lib/lacp.c ++