Re: [ovs-dev] [idl 3/4] ovsdb-idl: Improve ovsdb_idl_txn_increment() interface.

2012-04-12 Thread Ben Pfaff
Ethan, thanks, I removed it. Reid, thanks for the comment. I guess I don't really care about that test code, it's more or less disposable. Thanks, Ben. On Wed, Apr 11, 2012 at 11:23:40AM -0700, Ethan Jackson wrote: > There's some trailing whitespace in the Python. > > Otherwise looks good to

Re: [ovs-dev] [idl 3/4] ovsdb-idl: Improve ovsdb_idl_txn_increment() interface.

2012-04-11 Thread Ethan Jackson
There's some trailing whitespace in the Python. Otherwise looks good to me. Ethan On Tue, Mar 27, 2012 at 18:10, Reid Price wrote: > Glanced at python, seems good > > On Tue, Mar 27, 2012 at 5:00 PM, Ben Pfaff wrote: >> >> The previous interface was just bizarre. >> >> Signed-off-by: Ben Pfaff

Re: [ovs-dev] [idl 3/4] ovsdb-idl: Improve ovsdb_idl_txn_increment() interface.

2012-03-27 Thread Reid Price
Glanced at python, seems good On Tue, Mar 27, 2012 at 5:00 PM, Ben Pfaff wrote: > The previous interface was just bizarre. > > Signed-off-by: Ben Pfaff > --- > tests/test-ovsdb.py | 14 ++ > > > diff --git a/tests/test-ovsdb.py b/tests/test-ovsdb.py > index b0e42a3..77b3a2c 1

[ovs-dev] [idl 3/4] ovsdb-idl: Improve ovsdb_idl_txn_increment() interface.

2012-03-27 Thread Ben Pfaff
The previous interface was just bizarre. Signed-off-by: Ben Pfaff --- lib/ovsdb-idl.c | 41 - lib/ovsdb-idl.h |5 +++-- python/ovs/db/idl.py | 41 +++-- tests/ovsdb-idl.at|4 ++-- tests/test-