Thanks, I fixed both issues.
On Mon, Dec 19, 2011 at 02:31:36PM -0800, Ethan Jackson wrote:
> The includes in test-netflow.c are not in alphabetical order
> (particularly util.h).
>
> I think you need a comma before "interval" when printing
> hdr->sampling_interval.
>
> Otherwise looks good.
>
The includes in test-netflow.c are not in alphabetical order
(particularly util.h).
I think you need a comma before "interval" when printing hdr->sampling_interval.
Otherwise looks good.
Ethan
On Thu, Dec 8, 2011 at 14:01, Ben Pfaff wrote:
> These tests would have caught the flow statistics bu
These tests would have caught the flow statistics bug introduced by commit
501f8d1fd75 (ofproto-dpif: Batch interacting with the dpif on flow miss
operations.)
---
tests/automake.mk |4 +
tests/ofproto-dpif.at | 128 +++
tests/test-netflow.c | 323 +++
