All your comments sound reasonable.
Ethan
On Wed, Dec 14, 2011 at 09:25, Ben Pfaff wrote:
> On Tue, Dec 13, 2011 at 03:18:17PM -0800, Ethan Jackson wrote:
>> Why are min and max args 'int's instead of 'size_t's or 'unsigned'?
>
> I was drawing an analogy to main(), which has an "int" for argc.
>
On Tue, Dec 13, 2011 at 03:18:17PM -0800, Ethan Jackson wrote:
> Why are min and max args 'int's instead of 'size_t's or 'unsigned'?
I was drawing an analogy to main(), which has an "int" for argc.
> In ofproto/trace, you have a case which expects argc == 6, but you
> only allow a maximum of 4 (+
This looks like a huge win in terms of code cleanup. Comments below.
Why are min and max args 'int's instead of 'size_t's or 'unsigned'?
In ofproto/trace, you have a case which expects argc == 6, but you
only allow a maximum of 4 (+ 1 = 5) arguments when you register. It
looks like you are leav
The protocol used by ovs-appctl has a long-standing bug that there
is no way to distinguish "ovs-appctl a b c" from "ovs-appctl 'a b c'".
This isn't a big deal because none of the current commands really
want to accept arguments that include spaces, but it's kind of a silly
limitation.
At the same
