> Good point, here's a fixed version:
New version looks good to me.
Ethan
>
> /* Parses a subfield from the beginning of '*sp' into 'sf'. If successful,
> * returns NULL and advances '*sp' to the first byte following the parsed
> * string. On failure, returns a malloc()'d error message, does
On Mon, Jan 23, 2012 at 01:13:03PM -0800, Ethan Jackson wrote:
> In meta-flow.c
>
> In two places you mention ofp_mkerr() which no longer exists.
Fixed. (It existed when I wrote the code.)
> In mf_parse_subfield__() you modify 's' even if there's an error which
> would be fine if the comments d