It's not a huge deal if we skip looping; I'd rather have that happen
than abort().
Thanks,
Ben.
On Fri, Oct 21, 2011 at 06:11:40PM -0700, Ethan Jackson wrote:
> This looks fine to me.
>
> If FOR_EACH_MATCHING_TABLE is given an invalid TABLE_ID it simply
> skips looping. Would it make sense to
This looks fine to me.
If FOR_EACH_MATCHING_TABLE is given an invalid TABLE_ID it simply
skips looping. Would it make sense to force callers to check their
TABLE_ID's by replacing the "return NULL" of the else clause of
first_matching_table() to a NOT_REACHED()? I don't feel strongly
about it.
---
include/openflow/nicira-ext.h |9 -
ofproto/ofproto.c | 38 +++---
2 files changed, 39 insertions(+), 8 deletions(-)
diff --git a/include/openflow/nicira-ext.h b/include/openflow/nicira-ext.h
index 4fab6f1..fe725be 100644
--- a/include