I've merged this.
Ethan
On Sat, Sep 17, 2011 at 19:29, Ethan Jackson wrote:
>> If you are working entirely in python, you could switch some of this errno
>> passing into something more exception-based, it might look a little more
>> natural.
>
> I personally find exceptions aesthetically displea
> If you are working entirely in python, you could switch some of this errno
> passing into something more exception-based, it might look a little more
> natural.
I personally find exceptions aesthetically displeasing. They make
code hard to reason about. That said, I agree, if I were to rewrite
Seems reasonable.
If you are working entirely in python, you could switch some of this errno
passing into something more exception-based, it might look a little more
natural.
On Fri, Sep 16, 2011 at 4:49 PM, Ethan Jackson wrote:
> Pychecker complains about __read_pidfile() having too may return
Pychecker complains about __read_pidfile() having too may returns.
I personally think the function is fine, but it's easy enough to
reduce them.
python/ovs/daemon.py:395: Function (__read_pidfile) has too many
returns (12)
---
python/ovs/daemon.py |8 +---
1 files changed, 5 insertions(+)