Re: [ovs-dev] [=daemonpy 3/4] daemon.py: Don't shadow built-in 'file' variable.

2011-09-17 Thread Reid Price
Didn't look at the entire file, but the patch seems obviously correct. On Fri, Sep 16, 2011 at 6:28 PM, Ethan Jackson wrote: > Pychecker considers it bad style. > --- > > The original version of this patch that I sent out broke the unit tests. > Please review this version. > > --- > python/ovs/

[ovs-dev] [=daemonpy 3/4] daemon.py: Don't shadow built-in 'file' variable.

2011-09-16 Thread Ethan Jackson
Pychecker considers it bad style. --- The original version of this patch that I sent out broke the unit tests. Please review this version. --- python/ovs/daemon.py | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/python/ovs/daemon.py b/python/ovs/

[ovs-dev] [daemonpy 3/4] daemon.py: Don't shadow built-in 'file' variable.

2011-09-16 Thread Ethan Jackson
Pychecker considers it bad style. --- python/ovs/daemon.py | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/python/ovs/daemon.py b/python/ovs/daemon.py index a14be82..b793d6e 100644 --- a/python/ovs/daemon.py +++ b/python/ovs/daemon.py @@ -141,18 +141,1