Re: [ovs-dev] [coverity3 05/13] rconn: Clarify rconn_run_wait().

2011-02-23 Thread Ethan Jackson
Looks Fine. On Wed, Feb 23, 2011 at 1:24 PM, Ben Pfaff wrote: > At first glance the vconn_wait() call looks risky because this function > checked whether rc->vconn is nonnull at the top.  In fact it's OK because > rc->state will be S_ACTIVE or S_IDLE only if rc->vconn is nonnull, but > there's no

[ovs-dev] [coverity3 05/13] rconn: Clarify rconn_run_wait().

2011-02-23 Thread Ben Pfaff
At first glance the vconn_wait() call looks risky because this function checked whether rc->vconn is nonnull at the top. In fact it's OK because rc->state will be S_ACTIVE or S_IDLE only if rc->vconn is nonnull, but there's no harm in putting that check inside the block that only runs if rc->vconn