Re: [ovs-dev] [cmap v2 2/2] dpif-netdev: Use cmap for ports.

2014-05-21 Thread Ben Pfaff
On Wed, May 21, 2014 at 01:41:14PM -0700, Ben Pfaff wrote: > On Wed, May 21, 2014 at 01:37:38PM -0700, Jarno Rajahalme wrote: > > > > On May 20, 2014, at 5:11 PM, Ben Pfaff wrote: > > > > > Found it, I think. I'll send a series that includes fixes and then > > > the dpif-netdev conversion. > >

Re: [ovs-dev] [cmap v2 2/2] dpif-netdev: Use cmap for ports.

2014-05-21 Thread Ben Pfaff
On Wed, May 21, 2014 at 01:37:38PM -0700, Jarno Rajahalme wrote: > > On May 20, 2014, at 5:11 PM, Ben Pfaff wrote: > > > Found it, I think. I'll send a series that includes fixes and then > > the dpif-netdev conversion. > > Btw. it would be nice if the test suite Test results section would > l

Re: [ovs-dev] [cmap v2 2/2] dpif-netdev: Use cmap for ports.

2014-05-21 Thread Jarno Rajahalme
On May 20, 2014, at 5:11 PM, Ben Pfaff wrote: > Found it, I think. I'll send a series that includes fixes and then > the dpif-netdev conversion. Btw. it would be nice if the test suite Test results section would list any core files found on the tests/testsuite.dir// directories, so they w

Re: [ovs-dev] [cmap v2 2/2] dpif-netdev: Use cmap for ports.

2014-05-20 Thread Ben Pfaff
On Tue, May 20, 2014 at 05:03:59PM -0700, Ben Pfaff wrote: > On Tue, May 20, 2014 at 04:03:20PM -0700, Jarno Rajahalme wrote: > > > > On May 8, 2014, at 4:50 PM, Ben Pfaff wrote: > > > > > Signed-off-by: Ben Pfaff > > > --- > > > lib/dpif-netdev.c | 163 > > > +++--

Re: [ovs-dev] [cmap v2 2/2] dpif-netdev: Use cmap for ports.

2014-05-20 Thread Ben Pfaff
On Tue, May 20, 2014 at 04:03:20PM -0700, Jarno Rajahalme wrote: > > On May 8, 2014, at 4:50 PM, Ben Pfaff wrote: > > > Signed-off-by: Ben Pfaff > > --- > > lib/dpif-netdev.c | 163 > > +++-- > > 1 file changed, 82 insertions(+), 81 deletions(-)

Re: [ovs-dev] [cmap v2 2/2] dpif-netdev: Use cmap for ports.

2014-05-20 Thread Jarno Rajahalme
On May 20, 2014, at 4:11 PM, Jarno Rajahalme wrote: > unreeling unreffing ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [cmap v2 2/2] dpif-netdev: Use cmap for ports.

2014-05-20 Thread Jarno Rajahalme
On May 20, 2014, at 4:03 PM, Jarno Rajahalme wrote: > > On May 8, 2014, at 4:50 PM, Ben Pfaff wrote: > >> Signed-off-by: Ben Pfaff >> --- >> lib/dpif-netdev.c | 163 >> +++-- >> 1 file changed, 82 insertions(+), 81 deletions(-) >> >> diff --g

Re: [ovs-dev] [cmap v2 2/2] dpif-netdev: Use cmap for ports.

2014-05-20 Thread Jarno Rajahalme
On May 8, 2014, at 4:50 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > lib/dpif-netdev.c | 163 +++-- > 1 file changed, 82 insertions(+), 81 deletions(-) > > diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c > index 55712dd..b682876 100

Re: [ovs-dev] [cmap v2 2/2] dpif-netdev: Use cmap for ports.

2014-05-20 Thread Ben Pfaff
On Tue, May 20, 2014 at 12:25:50PM -0700, Jarno Rajahalme wrote: > Acked-by: Jarno Rajahalme Thanks. > > @@ -733,7 +731,7 @@ do_add_port(struct dp_netdev *dp, const char *devname, > > const char *type, > > } > > ovs_refcount_init(&port->ref_cnt); > > > > -hmap_insert(&dp->ports, &p

Re: [ovs-dev] [cmap v2 2/2] dpif-netdev: Use cmap for ports.

2014-05-20 Thread Jarno Rajahalme
On May 20, 2014, at 9:15 AM, Ben Pfaff wrote: > Did you have any further comments on v2? I ran out of time on Friday(?) and then forgot about this, sorry. I just sent an Acked-by with minor comments. Jarno ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] [cmap v2 2/2] dpif-netdev: Use cmap for ports.

2014-05-20 Thread Jarno Rajahalme
Ben, Minor comments below, Jarno Acked-by: Jarno Rajahalme On May 8, 2014, at 4:50 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > lib/dpif-netdev.c | 163 +++-- > 1 file changed, 82 insertions(+), 81 deletions(-) > > diff --git a/l

Re: [ovs-dev] [cmap v2 2/2] dpif-netdev: Use cmap for ports.

2014-05-20 Thread Ben Pfaff
Did you have any further comments on v2? ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [cmap v2 2/2] dpif-netdev: Use cmap for ports.

2014-05-08 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/dpif-netdev.c | 163 +++-- 1 file changed, 82 insertions(+), 81 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 55712dd..b682876 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -32,6