Re: [ovs-dev] [clang 0/4] fix clang-analyzer reports (including one crash bug)

2014-07-15 Thread Ben Pfaff
Thanks a lot! I must have good karma lately, because all my patches are getting reviewed quickly. I pushed all of these to master, and backported the first patch (the crasher bug) to all relevant branches (branch-2.[321]). On Mon, Jul 14, 2014 at 04:47:29PM -0700, Jarno Rajahalme wrote: > For al

Re: [ovs-dev] [clang 0/4] fix clang-analyzer reports (including one crash bug)

2014-07-14 Thread Jarno Rajahalme
For all four: Acked-by: Jarno Rajahalme On Jul 14, 2014, at 3:00 PM, Ben Pfaff wrote: > Ben Pfaff (4): > ofp-util: Fix null pointer dereference in ofputil_pull_buckets(). > ofproto: Avoid theoretical double free of large rule collections. > coverage: Move m_idx, h_idx to an inner scope in c

[ovs-dev] [clang 0/4] fix clang-analyzer reports (including one crash bug)

2014-07-14 Thread Ben Pfaff
Ben Pfaff (4): ofp-util: Fix null pointer dereference in ofputil_pull_buckets(). ofproto: Avoid theoretical double free of large rule collections. coverage: Move m_idx, h_idx to an inner scope in coverage_run(). Drop assignments whose values are never used. lib/coverage.c|8 +++---