Re: [ovs-dev] [clang-atomics 4/4] ovs-thread: Work around apparent Clang bug.

2013-08-21 Thread Ben Pfaff
On Tue, Aug 20, 2013 at 03:12:16PM -0700, Ben Pfaff wrote: > On Tue, Aug 20, 2013 at 05:05:26PM -0400, Ed Maste wrote: > > On 20 August 2013 14:10, Ben Pfaff wrote: > > > Without this patch, I get Clang warnings that I don't understand for each > > > of the non-static functions in dirs.c: > > > >

Re: [ovs-dev] [clang-atomics 4/4] ovs-thread: Work around apparent Clang bug.

2013-08-20 Thread Ben Pfaff
On Tue, Aug 20, 2013 at 05:05:26PM -0400, Ed Maste wrote: > On 20 August 2013 14:10, Ben Pfaff wrote: > > Without this patch, I get Clang warnings that I don't understand for each > > of the non-static functions in dirs.c: > > > > warning: control reaches end of non-void function > > This is

Re: [ovs-dev] [clang-atomics 4/4] ovs-thread: Work around apparent Clang bug.

2013-08-20 Thread Ed Maste
On 20 August 2013 14:10, Ben Pfaff wrote: > Without this patch, I get Clang warnings that I don't understand for each > of the non-static functions in dirs.c: > > warning: control reaches end of non-void function This is a clang bug; in your example the call to bar() is omitted by clang, and

[ovs-dev] [clang-atomics 4/4] ovs-thread: Work around apparent Clang bug.

2013-08-20 Thread Ben Pfaff
Without this patch, I get Clang warnings that I don't understand for each of the non-static functions in dirs.c: warning: control reaches end of non-void function I get the same warning for this test program with "clang -c -Wall": struct foo { const char *y; _Atomic(int)