Re: [ovs-dev] [bug15171 4/4] ofproto: Merge all the CFM query functions into one.

2013-03-06 Thread Ben Pfaff
On Tue, Mar 05, 2013 at 09:40:18PM -0800, Ben Pfaff wrote: > On Tue, Mar 05, 2013 at 05:02:25PM -0800, Ethan Jackson wrote: > > I think cfm_get_status() deserves a comment in ofproto-provider.h and > > ofproto.c, more out of convention than anything else. > > Oops. I overlooked that. I'll take c

Re: [ovs-dev] [bug15171 4/4] ofproto: Merge all the CFM query functions into one.

2013-03-05 Thread Ben Pfaff
On Tue, Mar 05, 2013 at 05:02:25PM -0800, Ethan Jackson wrote: > I think cfm_get_status() deserves a comment in ofproto-provider.h and > ofproto.c, more out of convention than anything else. Oops. I overlooked that. I'll take care of that in the morning and push this to master. Thanks for the r

Re: [ovs-dev] [bug15171 4/4] ofproto: Merge all the CFM query functions into one.

2013-03-05 Thread Ethan Jackson
I think cfm_get_status() deserves a comment in ofproto-provider.h and ofproto.c, more out of convention than anything else. Acked-by: Ethan Jackson On Tue, Mar 5, 2013 at 4:28 PM, Ben Pfaff wrote: > This eliminates several function calls and in particular several > hash table lookups to f

[ovs-dev] [bug15171 4/4] ofproto: Merge all the CFM query functions into one.

2013-03-05 Thread Ben Pfaff
This eliminates several function calls and in particular several hash table lookups to find structures corresponding to a port number from iface_refresh_cfm_stats(). This does not seem to reduce CPU use, but the code is shorter and more readable. Signed-off-by: Ben Pfaff --- ofproto/ofproto-dpi