Re: [ovs-dev] [bucket stats v3] ofp-util: compile group stats with visual studio

2014-05-08 Thread Andy Zhou
Thanks for the review. Pushed to master. On Thu, May 8, 2014 at 4:14 PM, Ben Pfaff wrote: > On Thu, May 08, 2014 at 04:05:55PM -0700, Andy Zhou wrote: >> Visual studio supports zero-size array within a struct or union, >> but has to be the last element. GCC does not have this restriction. >> >>

Re: [ovs-dev] [bucket stats v3] ofp-util: compile group stats with visual studio

2014-05-08 Thread Ben Pfaff
On Thu, May 08, 2014 at 04:05:55PM -0700, Andy Zhou wrote: > Visual studio supports zero-size array within a struct or union, > but has to be the last element. GCC does not have this restriction. > > Commits 644cfd84772eb7d8 and 6fdaa45a6f6c9 make use of 0 size array. > Remove them so that visual

[ovs-dev] [bucket stats v3] ofp-util: compile group stats with visual studio

2014-05-08 Thread Andy Zhou
Visual studio supports zero-size array within a struct or union, but has to be the last element. GCC does not have this restriction. Commits 644cfd84772eb7d8 and 6fdaa45a6f6c9 make use of 0 size array. Remove them so that visual studio can compile them as well. Reported-by: Gurucharan Shetty Sig