Re: [ovs-dev] [branch-2.3] revalidator: Eliminate duplicate flow handling.

2014-05-29 Thread Joe Stringer
I couldn't measure a difference in TCP_CRR. I dropped that part of the message from the patch that I sent for master: http://openvswitch.org/pipermail/dev/2014-May/040863.html On 28 May 2014 14:33, Joe Stringer wrote: > Yeah, I'd like to get a gauge of this as well. I'll follow up on this. > >

Re: [ovs-dev] [branch-2.3] revalidator: Eliminate duplicate flow handling.

2014-05-27 Thread Joe Stringer
Yeah, I'd like to get a gauge of this as well. I'll follow up on this. On 28 May 2014 14:28, Ethan Jackson wrote: > Could we measure if this actually causes a performance degradation? > I'd honestly be surprised if it does . . . My guess is our bottlenecks > are elsewhere, but perhaps they aren

Re: [ovs-dev] [branch-2.3] revalidator: Eliminate duplicate flow handling.

2014-05-27 Thread Ethan Jackson
Could we measure if this actually causes a performance degradation? I'd honestly be surprised if it does . . . My guess is our bottlenecks are elsewhere, but perhaps they aren't. Ethan On Tue, May 27, 2014 at 7:13 PM, Joe Stringer wrote: > Thanks for the Ack, I pushed this to branch-2.3. > > I'd

Re: [ovs-dev] [branch-2.3] revalidator: Eliminate duplicate flow handling.

2014-05-27 Thread Joe Stringer
Thanks for the Ack, I pushed this to branch-2.3. I'd like to send a patch for master anyway, in part so that we ensure to address this (fix the bug, and make the code more readable), and in part because it still matters if newer userspace is used with an older kernel. On 28 May 2014 13:52, Alex W

Re: [ovs-dev] [branch-2.3] revalidator: Eliminate duplicate flow handling.

2014-05-27 Thread Alex Wang
Acked-by: Alex Wang For master, I'm about to refactor the datapath so that we never dump duplicated flows. So, I think we should consider refactoring master after that. Thanks, Alex Wang, On Tue, May 27, 2014 at 6:19 PM, Joe Stringer wrote: > A series of bugs have been identified recently

Re: [ovs-dev] [branch-2.3] revalidator: Eliminate duplicate flow handling.

2014-05-27 Thread Joe Stringer
Due to the differences between master and branch-2.3 and pressure to get this out, I've targetted this first at branch-2.3. I intend to prepare an equivalent patch for master, separately. On 28 May 2014 13:19, Joe Stringer wrote: > A series of bugs have been identified recently that are caused

[ovs-dev] [branch-2.3] revalidator: Eliminate duplicate flow handling.

2014-05-27 Thread Joe Stringer
A series of bugs have been identified recently that are caused by a combination of the awkward flow dump API, possibility of duplicate flows in a flow dump, and premature optimisation of the revalidator logic. This patch attempts to simplify the revalidator logic by combining multiple critical sect