Re: [ovs-dev] [branch-2.1 branch-2.0 PATCH] datapath: Fix a bug.

2014-06-30 Thread Alex Wang
Thx Pravin, I'll address your comments. Also, will send the patch for branch-2.0 -> master On Mon, Jun 30, 2014 at 12:00 PM, Pravin Shelar wrote: > Good catch. > > > On Mon, Jun 30, 2014 at 10:59 AM, Alex Wang wrote: > > Due to the race condition in userspace, there is chance that two > > ove

Re: [ovs-dev] [branch-2.1 branch-2.0 PATCH] datapath: Fix a bug.

2014-06-30 Thread Pravin Shelar
Good catch. On Mon, Jun 30, 2014 at 10:59 AM, Alex Wang wrote: > Due to the race condition in userspace, there is chance that two > overlapping megaflows could be installed in datapath. And this > causes userspace unable to delete the less inclusive megaflow flow > even after it timeout, since

Re: [ovs-dev] [branch-2.1 branch-2.0 PATCH] datapath: Fix a bug.

2014-06-30 Thread Alex Wang
Sorry, this is only for branch-2.1. I'll start back/forward porting... On Mon, Jun 30, 2014 at 11:28 AM, Andy Zhou wrote: > Nice fix! Does this patch suppose to apply for branch-2.0? It only > applies to branch-2.1 for me. > > So for branch 2.1: > > Acked-by: Andy Zhou > > On Mon, Jun 30, 20

Re: [ovs-dev] [branch-2.1 branch-2.0 PATCH] datapath: Fix a bug.

2014-06-30 Thread Andy Zhou
Nice fix! Does this patch suppose to apply for branch-2.0? It only applies to branch-2.1 for me. So for branch 2.1: Acked-by: Andy Zhou On Mon, Jun 30, 2014 at 10:59 AM, Alex Wang wrote: > Due to the race condition in userspace, there is chance that two > overlapping megaflows could be instal

[ovs-dev] [branch-2.1 branch-2.0 PATCH] datapath: Fix a bug.

2014-06-30 Thread Alex Wang
Due to the race condition in userspace, there is chance that two overlapping megaflows could be installed in datapath. And this causes userspace unable to delete the less inclusive megaflow flow even after it timeout, since the flow_del logic will stop at the first match of masked flow. This comm