Re: [ovs-dev] [bond 5/7] bond: Revalidate when lacp_negotiated status changes.

2012-01-12 Thread Ben Pfaff
On Thu, Jan 12, 2012 at 05:10:42PM -0800, Ethan Jackson wrote: > > Should we commit this to earlier branches as a bug fix? ?It looks low > > risk to me. > > I'm not even sure if it's really a bug because whenever the > lacp_negotiated status changes, presumably the may_enable status of > one of th

Re: [ovs-dev] [bond 5/7] bond: Revalidate when lacp_negotiated status changes.

2012-01-12 Thread Ethan Jackson
> Should we commit this to earlier branches as a bug fix?  It looks low > risk to me. I'm not even sure if it's really a bug because whenever the lacp_negotiated status changes, presumably the may_enable status of one of the links will change as well. It's so edge case-ish that I wanted to put it

Re: [ovs-dev] [bond 5/7] bond: Revalidate when lacp_negotiated status changes.

2012-01-12 Thread Ben Pfaff
On Thu, Jan 12, 2012 at 11:40:02AM -0800, Ethan Jackson wrote: > Typically, when the lacp_negotiated flag changes, the result of > bond_is_tcp_hash() will change as well. However, for certain bond > types (SLB, Active-Backup, etc) this may not be true. Since the > lacp_negotiated flag affects the

[ovs-dev] [bond 5/7] bond: Revalidate when lacp_negotiated status changes.

2012-01-12 Thread Ethan Jackson
Typically, when the lacp_negotiated flag changes, the result of bond_is_tcp_hash() will change as well. However, for certain bond types (SLB, Active-Backup, etc) this may not be true. Since the lacp_negotiated flag affects the results of bond_check_admissibility() revalidation needs to happen whe