Re: [ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-26 Thread Kyle Mestery (kmestery)
On Apr 26, 2012, at 11:13 AM, Jesse Gross wrote: > On Thu, Apr 26, 2012 at 12:13 AM, Simon Horman wrote: >> On Wed, Apr 25, 2012 at 10:17:25AM -0700, Jesse Gross wrote: >>> On Wed, Apr 25, 2012 at 1:39 AM, Simon Horman wrote: Hi Kyle, the component that is of most interest

Re: [ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-26 Thread Jesse Gross
On Thu, Apr 26, 2012 at 12:13 AM, Simon Horman wrote: > On Wed, Apr 25, 2012 at 10:17:25AM -0700, Jesse Gross wrote: >> On Wed, Apr 25, 2012 at 1:39 AM, Simon Horman wrote: >> > >> > Hi Kyle, >> > >> > the component that is of most interest to me is enabling OVS to use in-tree >> > tunnelling cod

Re: [ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-26 Thread Simon Horman
On Wed, Apr 25, 2012 at 10:17:25AM -0700, Jesse Gross wrote: > On Wed, Apr 25, 2012 at 1:39 AM, Simon Horman wrote: > > > > Hi Kyle, > > > > the component that is of most interest to me is enabling OVS to use in-tree > > tunnelling code - as it seems that makes most sense for an implementation > >

Re: [ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-25 Thread Jesse Gross
On Wed, Apr 25, 2012 at 1:39 AM, Simon Horman wrote: > On Tue, Apr 24, 2012 at 04:02:41PM +, Kyle Mestery (kmestery) wrote: >> On Apr 23, 2012, at 9:25 PM, Simon Horman wrote: >> > On Mon, Apr 23, 2012 at 03:59:24PM -0700, Jesse Gross wrote: >> >> On Mon, Apr 23, 2012 at 3:32 PM, Simon Horman

Re: [ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-25 Thread Kyle Mestery (kmestery)
On Apr 25, 2012, at 3:39 AM, Simon Horman wrote: > On Tue, Apr 24, 2012 at 04:02:41PM +, Kyle Mestery (kmestery) wrote: >> On Apr 23, 2012, at 9:25 PM, Simon Horman wrote: >>> On Mon, Apr 23, 2012 at 03:59:24PM -0700, Jesse Gross wrote: On Mon, Apr 23, 2012 at 3:32 PM, Simon Horman wrote:

Re: [ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-25 Thread Simon Horman
On Tue, Apr 24, 2012 at 04:02:41PM +, Kyle Mestery (kmestery) wrote: > On Apr 23, 2012, at 9:25 PM, Simon Horman wrote: > > On Mon, Apr 23, 2012 at 03:59:24PM -0700, Jesse Gross wrote: > >> On Mon, Apr 23, 2012 at 3:32 PM, Simon Horman wrote: > >>> On Mon, Apr 23, 2012 at 02:38:07PM -0700, Jes

Re: [ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-24 Thread Kyle Mestery (kmestery)
On Apr 24, 2012, at 11:13 AM, Stephen Hemminger wrote: > On Tue, 24 Apr 2012 16:02:41 + > "Kyle Mestery (kmestery)" wrote: > >> On Apr 23, 2012, at 9:25 PM, Simon Horman wrote: >>> On Mon, Apr 23, 2012 at 03:59:24PM -0700, Jesse Gross wrote: On Mon, Apr 23, 2012 at 3:32 PM, Simon Horman

Re: [ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-24 Thread Stephen Hemminger
On Tue, 24 Apr 2012 16:02:41 + "Kyle Mestery (kmestery)" wrote: > On Apr 23, 2012, at 9:25 PM, Simon Horman wrote: > > On Mon, Apr 23, 2012 at 03:59:24PM -0700, Jesse Gross wrote: > >> On Mon, Apr 23, 2012 at 3:32 PM, Simon Horman wrote: > >>> On Mon, Apr 23, 2012 at 02:38:07PM -0700, Jesse

Re: [ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-24 Thread Kyle Mestery (kmestery)
On Apr 23, 2012, at 9:25 PM, Simon Horman wrote: > On Mon, Apr 23, 2012 at 03:59:24PM -0700, Jesse Gross wrote: >> On Mon, Apr 23, 2012 at 3:32 PM, Simon Horman wrote: >>> On Mon, Apr 23, 2012 at 02:38:07PM -0700, Jesse Gross wrote: On Mon, Apr 23, 2012 at 2:08 PM, David Miller wrote: >

Re: [ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-23 Thread Simon Horman
On Mon, Apr 23, 2012 at 09:40:57PM -0700, Stephen Hemminger wrote: > > > - Original Message - > > On Mon, Apr 23, 2012 at 03:59:24PM -0700, Jesse Gross wrote: > > > On Mon, Apr 23, 2012 at 3:32 PM, Simon Horman > > > wrote: > > > > On Mon, Apr 23, 2012 at 02:38:07PM -0700, Jesse Gross wr

Re: [ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-23 Thread Stephen Hemminger
- Original Message - > On Mon, Apr 23, 2012 at 03:59:24PM -0700, Jesse Gross wrote: > > On Mon, Apr 23, 2012 at 3:32 PM, Simon Horman > > wrote: > > > On Mon, Apr 23, 2012 at 02:38:07PM -0700, Jesse Gross wrote: > > >> On Mon, Apr 23, 2012 at 2:08 PM, David Miller > > >> wrote: > > >> >

Re: [ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-23 Thread Simon Horman
On Mon, Apr 23, 2012 at 03:59:24PM -0700, Jesse Gross wrote: > On Mon, Apr 23, 2012 at 3:32 PM, Simon Horman wrote: > > On Mon, Apr 23, 2012 at 02:38:07PM -0700, Jesse Gross wrote: > >> On Mon, Apr 23, 2012 at 2:08 PM, David Miller wrote: > >> > From: Jesse Gross > >> > Date: Mon, 23 Apr 2012 13

Re: [ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-23 Thread Jesse Gross
On Mon, Apr 23, 2012 at 3:32 PM, Simon Horman wrote: > On Mon, Apr 23, 2012 at 02:38:07PM -0700, Jesse Gross wrote: >> On Mon, Apr 23, 2012 at 2:08 PM, David Miller wrote: >> > From: Jesse Gross >> > Date: Mon, 23 Apr 2012 13:53:42 -0700 >> > >> >> On Mon, Apr 23, 2012 at 1:13 PM, David Miller

Re: [ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-23 Thread Simon Horman
On Mon, Apr 23, 2012 at 02:38:07PM -0700, Jesse Gross wrote: > On Mon, Apr 23, 2012 at 2:08 PM, David Miller wrote: > > From: Jesse Gross > > Date: Mon, 23 Apr 2012 13:53:42 -0700 > > > >> On Mon, Apr 23, 2012 at 1:13 PM, David Miller wrote: > >>> From: Jesse Gross > >>> Date: Mon, 23 Apr 2012

Re: [ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-23 Thread Jesse Gross
On Mon, Apr 23, 2012 at 2:08 PM, David Miller wrote: > From: Jesse Gross > Date: Mon, 23 Apr 2012 13:53:42 -0700 > >> On Mon, Apr 23, 2012 at 1:13 PM, David Miller wrote: >>> From: Jesse Gross >>> Date: Mon, 23 Apr 2012 13:08:49 -0700 >>> Assuming that the TCP stack generates large TSO fra

Re: [ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-23 Thread David Miller
From: Jesse Gross Date: Mon, 23 Apr 2012 13:53:42 -0700 > On Mon, Apr 23, 2012 at 1:13 PM, David Miller wrote: >> From: Jesse Gross >> Date: Mon, 23 Apr 2012 13:08:49 -0700 >> >>> Assuming that the TCP stack generates large TSO frames on transmit >>> (which could be the local stack; something s

Re: [ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-23 Thread Jesse Gross
On Mon, Apr 23, 2012 at 1:13 PM, David Miller wrote: > From: Jesse Gross > Date: Mon, 23 Apr 2012 13:08:49 -0700 > >> Assuming that the TCP stack generates large TSO frames on transmit >> (which could be the local stack; something sent by a VM; or packets >> received, coalesced by GRO and then en

Re: [ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-23 Thread David Miller
From: Jesse Gross Date: Mon, 23 Apr 2012 13:08:49 -0700 > Assuming that the TCP stack generates large TSO frames on transmit > (which could be the local stack; something sent by a VM; or packets > received, coalesced by GRO and then encapsulated by STT) then you can > just prepend the STT header

Re: [ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-23 Thread Jesse Gross
On Mon, Apr 23, 2012 at 12:19 PM, Stephen Hemminger wrote: > On Mon, 23 Apr 2012 15:15:33 -0400 (EDT) > David Miller wrote: > >> From: Simon Horman >> Date: Mon, 23 Apr 2012 17:30:08 +0900 >> >> > I'm pretty sure the patch I posted added encap_rcv to tcp_sock. >> > Am I missing the point? >> >>

Re: [ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-23 Thread Stephen Hemminger
On Mon, 23 Apr 2012 15:15:33 -0400 (EDT) David Miller wrote: > From: Simon Horman > Date: Mon, 23 Apr 2012 17:30:08 +0900 > > > I'm pretty sure the patch I posted added encap_rcv to tcp_sock. > > Am I missing the point? > > It did, my eyes are failing me :-) > > > Currently I am setting up a

Re: [ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-23 Thread David Miller
From: Simon Horman Date: Mon, 23 Apr 2012 17:30:08 +0900 > I'm pretty sure the patch I posted added encap_rcv to tcp_sock. > Am I missing the point? It did, my eyes are failing me :-) > Currently I am setting up a listening socket. The Open vSwtich tunneling > code transmits skbs and using eith

Re: [ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-23 Thread David Miller
From: Simon Horman Date: Mon, 23 Apr 2012 14:14:02 +0900 > On Sun, Apr 22, 2012 at 11:54:42AM -0400, Jamal Hadi Salim wrote: >> On Sun, 2012-04-22 at 08:22 -0700, Stephen Hemminger wrote: >> >> > STT isn't really doing TCP, it just lying and pretending to be >> > TCP to allow TSO to work! There

Re: [ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-22 Thread Simon Horman
On Sun, Apr 22, 2012 at 11:54:42AM -0400, Jamal Hadi Salim wrote: > On Sun, 2012-04-22 at 08:22 -0700, Stephen Hemminger wrote: > > > STT isn't really doing TCP, it just lying and pretending to be > > TCP to allow TSO to work! There is no packet ordering, sequence > > numbers or any real transport

Re: [ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-22 Thread Simon Horman
On Sun, Apr 22, 2012 at 08:24:35AM -0700, Stephen Hemminger wrote: > > > > This hook is based on a hook of the same name provided by UDP. It > > provides > > a way for to receive packets that have a TCP header and treat them in > > some > > alternate way. > > > > It is intended to be used by an

Re: [ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-22 Thread David Miller
From: Jamal Hadi Salim Date: Sun, 22 Apr 2012 11:54:42 -0400 > On Sun, 2012-04-22 at 08:22 -0700, Stephen Hemminger wrote: > >> Therefore Simon's >> proposed hook is the only way to support it. But exposing that >> hook does allow for other misuse. > > If you object to this, then you gotta obje

Re: [ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-22 Thread Jamal Hadi Salim
On Sun, 2012-04-22 at 08:22 -0700, Stephen Hemminger wrote: > STT isn't really doing TCP, it just lying and pretending to be > TCP to allow TSO to work! There is no packet ordering, sequence > numbers or any real transport layer. True. It is a nice engineering hack but even as a protocol enhance

Re: [ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-22 Thread Stephen Hemminger
> This hook is based on a hook of the same name provided by UDP. It > provides > a way for to receive packets that have a TCP header and treat them in > some > alternate way. > > It is intended to be used by an implementation of the STT tunneling > protocol within Open vSwtich's datapath. A pro

Re: [ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-22 Thread Stephen Hemminger
> From: Simon Horman > Date: Thu, 19 Apr 2012 13:53:35 +0900 > > > This hook is based on a hook of the same name provided by UDP. It > > provides > > a way for to receive packets that have a TCP header and treat them > > in some > > alternate way. > > > > It is intended to be used by an implem

Re: [ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-21 Thread David Miller
From: Simon Horman Date: Thu, 19 Apr 2012 13:53:35 +0900 > This hook is based on a hook of the same name provided by UDP. It provides > a way for to receive packets that have a TCP header and treat them in some > alternate way. > > It is intended to be used by an implementation of the STT tunne

[ovs-dev] [RFC v4] Add TCP encap_rcv hook (repost)

2012-04-18 Thread Simon Horman
This hook is based on a hook of the same name provided by UDP. It provides a way for to receive packets that have a TCP header and treat them in some alternate way. It is intended to be used by an implementation of the STT tunneling protocol within Open vSwtich's datapath. A prototype of such an