Re: [ovs-dev] [RFC recirc fix] recirculation: Map recirc_id to ofproto_dpif.

2014-12-20 Thread Alex Wang
Thx Andy for the review, Please see my reply below, > + * When recirc_id is set in 'flow', checks whether the ofproto_dpif that > > + * corresponds to the recirc_id is same as the receiving bridge. If > they are > > + * the same, uses the 'ofproto' and keeps the 'ofp_in_port' as assigned. > > +

Re: [ovs-dev] [RFC recirc fix] recirculation: Map recirc_id to ofproto_dpif.

2014-12-19 Thread Andy Zhou
Alex, thanks for the fast turn around in sending out the patch. A few comments in line. On Thu, Dec 18, 2014 at 9:46 PM, Alex Wang wrote: > After commit 0c7812e5e (recirculation: Do not drop packet when > there is no match from internal table.), if flow keys are modified > before the recirculatio

[ovs-dev] [RFC recirc fix] recirculation: Map recirc_id to ofproto_dpif.

2014-12-18 Thread Alex Wang
After commit 0c7812e5e (recirculation: Do not drop packet when there is no match from internal table.), if flow keys are modified before the recirculation action (e.g. set vlan ID), the miss handling of recirc'ed packets may not reach the intended 'ofproto_dpif' which has rules looking up the 'reci