Re: [ovs-dev] [RFC bashcomp] ovs-vsctl-bashcomp: Avoid setting the COMP_WORDBREAKS.

2015-03-16 Thread Alex Wang
Haven't heard back from Peter, I fixed the unittest failure and added the 'make install' + package install~ Resend RFC to master. Thanks, Alex Wang, On Fri, Mar 13, 2015 at 4:57 PM, Alex Wang wrote: > Hey Ben, Peter, > > I did some hack to avoid setting the $COMP_WORDBREAKS (based on this > l

Re: [ovs-dev] [RFC bashcomp] ovs-vsctl-bashcomp: Avoid setting the COMP_WORDBREAKS.

2015-03-13 Thread Alex Wang
Hey Ben, Peter, I did some hack to avoid setting the $COMP_WORDBREAKS (based on this link http://stackoverflow.com/questions/10528695/how-to-reset-comp-wordbreaks-without-effecting-other-completion-script ). This patch breaks the unittest. Want to hear some feedback before fixing the tests. Tha

[ovs-dev] [RFC bashcomp] ovs-vsctl-bashcomp: Avoid setting the COMP_WORDBREAKS.

2015-03-13 Thread Alex Wang
Modifying $COMP_WORDBREAKS in completion script is not the recommended as it is a global variable and the modification could affect the behavior of other completion scripts. As a workaround, this commit uses the _get_comp_words_by_ref which allows user to exclude characters out of $COMP_WORDBREAKS