> On Jul 16, 2015, at 1:21 PM, Ben Pfaff wrote:
>
> On Thu, Jul 16, 2015 at 01:12:34PM -0700, Jarno Rajahalme wrote:
>> I think the right fix here is to eliminate the ‘values’ field and
>> reintroduce the miniflow_get_values() getter. I’ll post a patch to
>> that effect as part of the v3 of the
On Thu, Jul 16, 2015 at 01:12:34PM -0700, Jarno Rajahalme wrote:
> I think the right fix here is to eliminate the ‘values’ field and
> reintroduce the miniflow_get_values() getter. I’ll post a patch to
> that effect as part of the v3 of the rest of the series.
Good idea. I've often found that tra
3337) : error C2233: 'keys' : arrays of objects containing
> zero-size arrays are illegal
> lib/dpif-netdev.c(3881) : error C2233: 'keys' : arrays of objects containing
> zero-size arrays are illegal
> lib/dpif-netdev.c(3883) : warning C4028: formal parameter 4 di
Alin.
-Mesaj original-
De la: Ben Pfaff [mailto:b...@nicira.com]
Trimis: Thursday, July 16, 2015 10:27 AM
Către: Alin Serdean
Cc: Jarno Rajahalme; dev@openvswitch.org
Subiect: Re: [ovs-dev] [RFC PATCH v2 3/7] flow: Always inline miniflows.
On Thu, Jul 16, 2015 at 01:35:14AM +, Alin Se
On Thu, Jul 16, 2015 at 01:35:14AM +, Alin Serdean wrote:
> Hi Jarno,
>
> This is breaking the windows build
> (https://ci.appveyor.com/project/blp/ovs/build/1.0.459):
> lib/classifier.c(1355) : error C2229: struct '' has an illegal
> zero-sized array.
>
> The problem is the following
> (h
15 1:59 AM
Către: Ben Pfaff
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev] [RFC PATCH v2 3/7] flow: Always inline miniflows.
Thanks for the review, pushed to master.
Jarno
> On Jul 15, 2015, at 3:05 PM, Ben Pfaff wrote:
>
> On Wed, Jul 15, 2015 at 01:11:54PM -0700, Jarno Rajahalme wrote
Thanks for the review, pushed to master.
Jarno
> On Jul 15, 2015, at 3:05 PM, Ben Pfaff wrote:
>
> On Wed, Jul 15, 2015 at 01:11:54PM -0700, Jarno Rajahalme wrote:
>>
>>> On Jul 14, 2015, at 4:50 PM, Ben Pfaff wrote:
>>>
>>> On Fri, Jul 10, 2015 at 10:35:21AM -0700, Jarno Rajahalme wrote:
On Wed, Jul 15, 2015 at 01:11:54PM -0700, Jarno Rajahalme wrote:
>
> > On Jul 14, 2015, at 4:50 PM, Ben Pfaff wrote:
> >
> > On Fri, Jul 10, 2015 at 10:35:21AM -0700, Jarno Rajahalme wrote:
> >> Now that performance critical code already inlines miniflows and
> >> minimasks, we can simplify stru
> On Jul 14, 2015, at 4:50 PM, Ben Pfaff wrote:
>
> On Fri, Jul 10, 2015 at 10:35:21AM -0700, Jarno Rajahalme wrote:
>> Now that performance critical code already inlines miniflows and
>> minimasks, we can simplify struct miniflow by always dynamically
>> allocating miniflows and minimasks to th
On Fri, Jul 10, 2015 at 10:35:21AM -0700, Jarno Rajahalme wrote:
> Now that performance critical code already inlines miniflows and
> minimasks, we can simplify struct miniflow by always dynamically
> allocating miniflows and minimasks to the correct size. This changes
> the struct minimatch to al
Now that performance critical code already inlines miniflows and
minimasks, we can simplify struct miniflow by always dynamically
allocating miniflows and minimasks to the correct size. This changes
the struct minimatch to always contain pointers to its miniflow and
minimask.
Signed-off-by: Jarno
11 matches
Mail list logo
