On Jun 25, 2013, at 22:38 , ext Ben Pfaff wrote:
...
> I'm not fond of the structure of the new ofpacts_check_ctx(). At a
> minimum, I think that ofpacts_check() should be a trivial wrapper
> around it (just change ofpacts_check_ctx() to ignore 'ctx' if it's
> NULL). But the inversion of control
In fact OpenFlow 1.4 adds such a code:
/* Why was this flow removed? */
enum ofp_flow_removed_reason {
OFPRR_IDLE_TIMEOUT = 0, /* Flow idle time exceeded idle_timeout. */
OFPRR_HARD_TIMEOUT = 1, /* Time exceeded hard_timeout. */
OFPRR_DELETE = 2, /* Evicted by a DELET
Ben,
On a related note, the patch that you already applied added a new
ofp_flow_removed_reason code OFPRR_METER_DELETE (in openflow-common.h). I
intended to have some discussion on it, but forgot to point it out. There is a
corresponding OFPRR_GROUP_DELETE reason code, but the OF spec does not
On Tue, Jun 25, 2013 at 12:38:32PM -0700, Ben Pfaff wrote:
> We can add a "bad meter" extension error very easily by editing
> ofp-errors.h. Feel free to use the Nicira extension namespace for
> this, or you could easily add a Nokia-Siemens extension namespace by
> adding a *_VENDOR_ID to openflow
On Thu, Jun 20, 2013 at 05:26:19PM +0300, Jarno Rajahalme wrote:
>
> Signed-off-by: Jarno Rajahalme
I rebased this patch against master and resolved a bunch of conflicts
to come up with the appended patch.
I have some comments on this patch.
We can add a "bad meter" extension error very easily
Signed-off-by: Jarno Rajahalme
---
lib/ofp-actions.c | 35 +++-
lib/ofp-actions.h | 14 ++
lib/rconn.c| 14 +-
ofproto/ofproto-dpif.c | 33
ofproto/ofproto-provider.h | 24 +++
ofproto/ofproto.c | 467
