Re: [ovs-dev] [RFC PATCH 4/4] lib/ofpbuf: Compact

2014-04-02 Thread Lori Jakab
On 4/2/14, 9:09 PM, Jarno Rajahalme wrote: On Apr 1, 2014, at 1:28 PM, Lori Jakab > wrote: On 4/1/14, 5:43 PM, Jarno Rajahalme wrote: Sent from my iPhone On Apr 1, 2014, at 7:27 AM, Ben Pfaff > wrote: On Tue, Apr 01, 2014 at 03:14:16PM +

Re: [ovs-dev] [RFC PATCH 4/4] lib/ofpbuf: Compact

2014-04-02 Thread Jarno Rajahalme
On Apr 1, 2014, at 1:28 PM, Lori Jakab wrote: > On 4/1/14, 5:43 PM, Jarno Rajahalme wrote: >> >> Sent from my iPhone >> >>> On Apr 1, 2014, at 7:27 AM, Ben Pfaff wrote: >>> On Tue, Apr 01, 2014 at 03:14:16PM +0300, Lori Jakab wrote: >>> Can we do the following? >>>3) Replace 'l2' by

Re: [ovs-dev] [RFC PATCH 4/4] lib/ofpbuf: Compact

2014-04-01 Thread Lori Jakab
On 4/1/14, 5:43 PM, Jarno Rajahalme wrote: Sent from my iPhone On Apr 1, 2014, at 7:27 AM, Ben Pfaff wrote: On Tue, Apr 01, 2014 at 03:14:16PM +0300, Lori Jakab wrote: On 3/26/14, 2:16 AM, Ben Pfaff wrote: On Mon, Mar 24, 2014 at 10:59:06AM -0700, Jarno Rajahalme wrote: This patch shrinks

Re: [ovs-dev] [RFC PATCH 4/4] lib/ofpbuf: Compact

2014-04-01 Thread Jarno Rajahalme
Sent from my iPhone > On Apr 1, 2014, at 7:27 AM, Ben Pfaff wrote: > >> On Tue, Apr 01, 2014 at 03:14:16PM +0300, Lori Jakab wrote: >>> On 3/26/14, 2:16 AM, Ben Pfaff wrote: On Mon, Mar 24, 2014 at 10:59:06AM -0700, Jarno Rajahalme wrote: This patch shrinks the struct ofpbuf from 104

Re: [ovs-dev] [RFC PATCH 4/4] lib/ofpbuf: Compact

2014-04-01 Thread Ben Pfaff
On Tue, Apr 01, 2014 at 03:14:16PM +0300, Lori Jakab wrote: > On 3/26/14, 2:16 AM, Ben Pfaff wrote: > >On Mon, Mar 24, 2014 at 10:59:06AM -0700, Jarno Rajahalme wrote: > >>This patch shrinks the struct ofpbuf from 104 to 48 bytes on 64-bit > >>systems, or from 52 to 36 bytes on 32-bit systems (coun

Re: [ovs-dev] [RFC PATCH 4/4] lib/ofpbuf: Compact

2014-04-01 Thread Lori Jakab
On 3/26/14, 2:16 AM, Ben Pfaff wrote: On Mon, Mar 24, 2014 at 10:59:06AM -0700, Jarno Rajahalme wrote: This patch shrinks the struct ofpbuf from 104 to 48 bytes on 64-bit systems, or from 52 to 36 bytes on 32-bit systems (counting in the 'l7' removal by the previous patch). This may help contri

Re: [ovs-dev] [RFC PATCH 4/4] lib/ofpbuf: Compact

2014-03-31 Thread Ben Pfaff
On Sat, Mar 29, 2014 at 05:47:18PM -0700, Jarno Rajahalme wrote: > Thanks for the review! Pushed to master with the proposed changes. See a > small comment below, though. > > Jarno > > On Mar 25, 2014, at 5:16 PM, Ben Pfaff wrote: > > > On Mon, Mar 24, 2014 at 10:59:06AM -0700, Jarno Rajahalm

Re: [ovs-dev] [RFC PATCH 4/4] lib/ofpbuf: Compact

2014-03-29 Thread Jarno Rajahalme
Thanks for the review! Pushed to master with the proposed changes. See a small comment below, though. Jarno On Mar 25, 2014, at 5:16 PM, Ben Pfaff wrote: > On Mon, Mar 24, 2014 at 10:59:06AM -0700, Jarno Rajahalme wrote: >> This patch shrinks the struct ofpbuf from 104 to 48 bytes on 64-bit >

Re: [ovs-dev] [RFC PATCH 4/4] lib/ofpbuf: Compact

2014-03-25 Thread Ben Pfaff
On Mon, Mar 24, 2014 at 10:59:06AM -0700, Jarno Rajahalme wrote: > This patch shrinks the struct ofpbuf from 104 to 48 bytes on 64-bit > systems, or from 52 to 36 bytes on 32-bit systems (counting in the > 'l7' removal by the previous patch). This may help contribute to > cache efficiency, and wil