Re: [ovs-dev] [RFC PATCH 2/8] ofpacts_check: Remove unnecessary flow copying.

2013-06-24 Thread Ben Pfaff
On Mon, Jun 24, 2013 at 03:26:52PM +, Rajahalme, Jarno (NSN - FI/Espoo) wrote: > > On Jun 20, 2013, at 23:36 , ext Ben Pfaff wrote: > > > On Thu, Jun 20, 2013 at 05:26:17PM +0300, Jarno Rajahalme wrote: > >> > >> Signed-off-by: Jarno Rajahalme > > > > I have mixed feelings here. On one h

Re: [ovs-dev] [RFC PATCH 2/8] ofpacts_check: Remove unnecessary flow copying.

2013-06-24 Thread Rajahalme, Jarno (NSN - FI/Espoo)
On Jun 20, 2013, at 23:36 , ext Ben Pfaff wrote: > On Thu, Jun 20, 2013 at 05:26:17PM +0300, Jarno Rajahalme wrote: >> >> Signed-off-by: Jarno Rajahalme > > I have mixed feelings here. On one hand, it is nice to avoid a big > copy in some cases (rare cases really). But on the other hand I am

Re: [ovs-dev] [RFC PATCH 2/8] ofpacts_check: Remove unnecessary flow copying.

2013-06-20 Thread Ben Pfaff
On Thu, Jun 20, 2013 at 05:26:17PM +0300, Jarno Rajahalme wrote: > > Signed-off-by: Jarno Rajahalme I have mixed feelings here. On one hand, it is nice to avoid a big copy in some cases (rare cases really). But on the other hand I am not fond of interfaces that temporarily modify data, even if

[ovs-dev] [RFC PATCH 2/8] ofpacts_check: Remove unnecessary flow copying.

2013-06-20 Thread Jarno Rajahalme
Signed-off-by: Jarno Rajahalme --- lib/ofp-actions.c | 34 +++--- lib/ofp-actions.h |3 ++- 2 files changed, 13 insertions(+), 24 deletions(-) diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c index c9e000f..7a2851e 100644 --- a/lib/ofp-actions.c +++ b/lib/ofp