Re: [ovs-dev] [RFC PATCH 1/2] Widen TCP flags handling.

2013-09-24 Thread Ben Pfaff
OK. The netflow stuff is purely userspace. On Tue, Sep 24, 2013 at 04:57:33PM -0700, Jarno Rajahalme wrote: > Ben, > > All valid points, will address once I hear back from Jesse or Pravin. > > Thanks, > > Jarno > > On Sep 24, 2013, at 4:50 PM, Ben Pfaff wrote: > > > On Wed, Sep 18, 2013 a

Re: [ovs-dev] [RFC PATCH 1/2] Widen TCP flags handling.

2013-09-24 Thread Jarno Rajahalme
Ben, All valid points, will address once I hear back from Jesse or Pravin. Thanks, Jarno On Sep 24, 2013, at 4:50 PM, Ben Pfaff wrote: > On Wed, Sep 18, 2013 at 01:42:40PM -0700, Jarno Rajahalme wrote: >> Widen TCP flags handling from 7 bits (uint8_t) to 12 >> bits (uint16_t). The kernel i

Re: [ovs-dev] [RFC PATCH 1/2] Widen TCP flags handling.

2013-09-24 Thread Ben Pfaff
On Wed, Sep 18, 2013 at 01:42:40PM -0700, Jarno Rajahalme wrote: > Widen TCP flags handling from 7 bits (uint8_t) to 12 > bits (uint16_t). The kernel interface remains at 8 > bits, which makes no functional difference now, as none > of the higher bits is currenlty of interest to the "currently"

[ovs-dev] [RFC PATCH 1/2] Widen TCP flags handling.

2013-09-18 Thread Jarno Rajahalme
Widen TCP flags handling from 7 bits (uint8_t) to 12 bits (uint16_t). The kernel interface remains at 8 bits, which makes no functional difference now, as none of the higher bits is currenlty of interest to the userspace. Signed-off-by: Jarno Rajahalme --- datapath/datapath.c |2 +-