Re: [ovs-dev] [RFC PATCH 07/14] Add APIs to set NSH keys for match fields

2016-06-22 Thread Jesse Gross
On Tue, Jun 21, 2016 at 7:40 PM, Li, Johnson wrote: >> On Tue, Jun 21, 2016 at 6:50 PM, Li, Johnson wrote: >> >> Please make a generalized push/pop Ethernet header rather than a >> >> specialized one for this case. There are other use cases that involve >> >> this and they should be consistent (i

Re: [ovs-dev] [RFC PATCH 07/14] Add APIs to set NSH keys for match fields

2016-06-21 Thread Li, Johnson
> > On Tue, Jun 21, 2016 at 6:50 PM, Li, Johnson wrote: > >> On Mon, Jun 20, 2016 at 9:02 PM, Li, Johnson > wrote: > > [JL] Yes, Mengke had renamed the command line and mapping table from > > xx-geneve-yy To xx-tlv-yy. However, the flow fields are still named > > TUN_ and bind to geneve Tunn

Re: [ovs-dev] [RFC PATCH 07/14] Add APIs to set NSH keys for match fields

2016-06-21 Thread Jesse Gross
On Tue, Jun 21, 2016 at 6:50 PM, Li, Johnson wrote: >> On Mon, Jun 20, 2016 at 9:02 PM, Li, Johnson wrote: >> > 2) Add framework codes (or full implementation) for MD type 2 support of >> > the NSH header. According to the discussion at >> > http://comments.gmane.org/gmane.network.o

Re: [ovs-dev] [RFC PATCH 07/14] Add APIs to set NSH keys for match fields

2016-06-21 Thread Li, Johnson
> On Mon, Jun 20, 2016 at 9:02 PM, Li, Johnson wrote: > > 2) Add framework codes (or full implementation) for MD type 2 support of > > the NSH header. According to the discussion at > > http://comments.gmane.org/gmane.network.openvswitch.devel/53788 > > I will reuse the definit

Re: [ovs-dev] [RFC PATCH 07/14] Add APIs to set NSH keys for match fields

2016-06-21 Thread Yang, Yi
On Tue, Jun 21, 2016 at 02:08:34PM -0700, Jesse Gross wrote: > On Mon, Jun 20, 2016 at 9:02 PM, Li, Johnson wrote: > > 2) Add framework codes (or full implementation) for MD type 2 support of > > the NSH header. According to the discussion at > > http://comments.gmane.org/gmane.netwo

Re: [ovs-dev] [RFC PATCH 07/14] Add APIs to set NSH keys for match fields

2016-06-21 Thread Jesse Gross
On Mon, Jun 20, 2016 at 9:02 PM, Li, Johnson wrote: > 2) Add framework codes (or full implementation) for MD type 2 support of > the NSH header. According to the discussion at > http://comments.gmane.org/gmane.network.openvswitch.devel/53788 > I will reuse the definitions for M

Re: [ovs-dev] [RFC PATCH 07/14] Add APIs to set NSH keys for match fields

2016-06-20 Thread Li, Johnson
> > > > > Regards > > _Sugesh > > > > > > [Sugesh] I feel, match_set for every nsh field is a overkill > > especially when we implement NSH type-2? Can we do this some more > optimized way? > > Consider the MD2 type as well when defining the match_set definitions. > > > [JL] I will try to use MACR

Re: [ovs-dev] [RFC PATCH 07/14] Add APIs to set NSH keys for match fields

2016-06-19 Thread Li, Johnson
> > Regards > _Sugesh > > > > -Original Message- > > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Johnson Li > > Sent: Thursday, June 16, 2016 10:52 AM > > To: dev@openvswitch.org > > Subject: [ovs-dev] [RFC PATCH 07/14]

Re: [ovs-dev] [RFC PATCH 07/14] Add APIs to set NSH keys for match fields

2016-06-16 Thread Chandran, Sugesh
Regards _Sugesh > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Johnson Li > Sent: Thursday, June 16, 2016 10:52 AM > To: dev@openvswitch.org > Subject: [ovs-dev] [RFC PATCH 07/14] Add APIs to set NSH keys for match > fields

[ovs-dev] [RFC PATCH 07/14] Add APIs to set NSH keys for match fields

2016-06-15 Thread Johnson Li
Signed-off-by: Johnson Li diff --git a/include/openvswitch/match.h b/include/openvswitch/match.h index c955753..a1cca7e 100644 --- a/include/openvswitch/match.h +++ b/include/openvswitch/match.h @@ -86,6 +86,26 @@ void match_set_tun_gbp_id_masked(struct match *match, ovs_be16 gbp_id, ovs_be16 v