Re: [ovs-dev] [RFC 02/14] dpif: Zero flow before dpif_flow_get().

2014-08-24 Thread Joe Stringer
On 23 August 2014 06:29, Ben Pfaff wrote: > On Thu, Aug 21, 2014 at 05:41:57PM +1200, Joe Stringer wrote: > > Signed-off-by: Joe Stringer > > My reading of the code is that this is redundant because > dpif_operate() always fills in the flow. > Right, this is needed in a later patch. I'll look a

Re: [ovs-dev] [RFC 02/14] dpif: Zero flow before dpif_flow_get().

2014-08-22 Thread Ben Pfaff
On Thu, Aug 21, 2014 at 05:41:57PM +1200, Joe Stringer wrote: > Signed-off-by: Joe Stringer My reading of the code is that this is redundant because dpif_operate() always fills in the flow. ___ dev mailing list dev@openvswitch.org http://openvswitch.org

[ovs-dev] [RFC 02/14] dpif: Zero flow before dpif_flow_get().

2014-08-20 Thread Joe Stringer
Signed-off-by: Joe Stringer --- lib/dpif.c |1 + 1 file changed, 1 insertion(+) diff --git a/lib/dpif.c b/lib/dpif.c index b2a1972..1a32ef6 100644 --- a/lib/dpif.c +++ b/lib/dpif.c @@ -840,6 +840,7 @@ dpif_flow_get(struct dpif *dpif, struct dpif_op *opp; struct dpif_op op; +m