Applied to master and branch-2.4,
Thanks,
Alex Wang,
On Mon, Jul 20, 2015 at 9:58 AM, Alex Wang wrote:
> Thx for the review, I'll adopt the comment~
>
> On Mon, Jul 20, 2015 at 9:47 AM, Ben Pfaff wrote:
>
>> On Mon, Jul 20, 2015 at 08:50:39AM -0700, Alex Wang wrote:
>> > On Mon, Jul 20, 2015 a
Thx for the review, I'll adopt the comment~
On Mon, Jul 20, 2015 at 9:47 AM, Ben Pfaff wrote:
> On Mon, Jul 20, 2015 at 08:50:39AM -0700, Alex Wang wrote:
> > On Mon, Jul 20, 2015 at 8:17 AM, Ben Pfaff wrote:
> >
> > > On Mon, Jul 20, 2015 at 01:22:32AM -0700, Alex Wang wrote:
> > > > Commit 6f
On Mon, Jul 20, 2015 at 08:50:39AM -0700, Alex Wang wrote:
> On Mon, Jul 20, 2015 at 8:17 AM, Ben Pfaff wrote:
>
> > On Mon, Jul 20, 2015 at 01:22:32AM -0700, Alex Wang wrote:
> > > Commit 6fd6ed7 (ofpbuf: Simplify ofpbuf API.) introduced the
> > > 'header' and 'msg' pointers to 'struct ofpbuf'.
On Mon, Jul 20, 2015 at 8:17 AM, Ben Pfaff wrote:
> On Mon, Jul 20, 2015 at 01:22:32AM -0700, Alex Wang wrote:
> > Commit 6fd6ed7 (ofpbuf: Simplify ofpbuf API.) introduced the
> > 'header' and 'msg' pointers to 'struct ofpbuf'. However, we
> > forget to update the 'msg' pointer when resizing ofp
On Mon, Jul 20, 2015 at 01:22:32AM -0700, Alex Wang wrote:
> Commit 6fd6ed7 (ofpbuf: Simplify ofpbuf API.) introduced the
> 'header' and 'msg' pointers to 'struct ofpbuf'. However, we
> forget to update the 'msg' pointer when resizing ofpbuf.
>
> This bug could cause serious issue. For example,
Commit 6fd6ed7 (ofpbuf: Simplify ofpbuf API.) introduced the
'header' and 'msg' pointers to 'struct ofpbuf'. However, we
forget to update the 'msg' pointer when resizing ofpbuf.
This bug could cause serious issue. For example, in the function
ofputil_encode_nx_packet_in(), the 'msg' pointer is p