Re: [ovs-dev] [RFC] datapath/flow_netlink: Create right mask with disabled megaflows

2014-07-10 Thread Daniele Di Proietto
Thanks for the review, I’ve fixed the two memory leaks and expanded the comment. I’m about to post a v2. Let mw know if you think the patch could be improved further. Daniele On Jul 10, 2014, at 3:27 PM, Pravin Shelar wrote: > On Wed, Jul 9, 2014 at 3:30 PM, Daniele Di Proietto > wrote: >> I

Re: [ovs-dev] [RFC] datapath/flow_netlink: Create right mask with disabled megaflows

2014-07-10 Thread Pravin Shelar
On Wed, Jul 9, 2014 at 3:30 PM, Daniele Di Proietto wrote: > If megaflows are disabled, the userspace does not send the netlink attribute > OVS_FLOW_ATTR_MASK, and the kernel must create an exact match mask. > > sw_flow_mask_set() sets every bytes (in 'range') of the mask to 0xff, even the > bytes

[ovs-dev] [RFC] datapath/flow_netlink: Create right mask with disabled megaflows

2014-07-09 Thread Daniele Di Proietto
If megaflows are disabled, the userspace does not send the netlink attribute OVS_FLOW_ATTR_MASK, and the kernel must create an exact match mask. sw_flow_mask_set() sets every bytes (in 'range') of the mask to 0xff, even the bytes that represent padding for struct sw_flow, or the bytes that represe