Re: [ovs-dev] [PATCHv6 14/14] udpif: Simplify storage of key, mask in udpif_key.

2014-10-06 Thread Joe Stringer
I dropped this patch for the moment, it'll be easier to take a fresh look once the bulk of the changes are in. On 30 September 2014 16:21, Joe Stringer wrote: > On 30 September 2014 10:27, Ben Pfaff wrote: > >> On Fri, Sep 26, 2014 at 09:28:18PM +1200, Joe Stringer wrote: >> > Previously we sto

Re: [ovs-dev] [PATCHv6 14/14] udpif: Simplify storage of key, mask in udpif_key.

2014-09-29 Thread Joe Stringer
On 30 September 2014 10:27, Ben Pfaff wrote: > On Fri, Sep 26, 2014 at 09:28:18PM +1200, Joe Stringer wrote: > > Previously we stored the netlink-formatted version of a flow key and > > mask in 'struct udpif_key'. This patch stores the original key,mask > > in the 'struct match' format, which red

Re: [ovs-dev] [PATCHv6 14/14] udpif: Simplify storage of key, mask in udpif_key.

2014-09-29 Thread Ben Pfaff
On Fri, Sep 26, 2014 at 09:28:18PM +1200, Joe Stringer wrote: > Previously we stored the netlink-formatted version of a flow key and > mask in 'struct udpif_key'. This patch stores the original key,mask > in the 'struct match' format, which reduces the size of a ukey from 1216 > bytes to 560. Furth

[ovs-dev] [PATCHv6 14/14] udpif: Simplify storage of key, mask in udpif_key.

2014-09-26 Thread Joe Stringer
Previously we stored the netlink-formatted version of a flow key and mask in 'struct udpif_key'. This patch stores the original key,mask in the 'struct match' format, which reduces the size of a ukey from 1216 bytes to 560. Furthermore, this reduces netlink conversions required and simplifies mask