Re: [ovs-dev] [PATCHv6 13/14] dpif: Minimize memory copy for revalidation.

2014-10-07 Thread Ben Pfaff
On Wed, Oct 01, 2014 at 08:44:58PM +1300, Joe Stringer wrote: > On 30 September 2014 10:24, Ben Pfaff wrote: > > > I suspect that check_recirc() and check_uid() should pass > > DPIF_FP_MODIFY as well as DPIF_FP_CREATE, just in case a previous run > > of OVS was killed at just the right time to le

Re: [ovs-dev] [PATCHv6 13/14] dpif: Minimize memory copy for revalidation.

2014-10-01 Thread Joe Stringer
On 30 September 2014 10:24, Ben Pfaff wrote: > I suspect that check_recirc() and check_uid() should pass > DPIF_FP_MODIFY as well as DPIF_FP_CREATE, just in case a previous run > of OVS was killed at just the right time to leave a straggler probe > flow in the datapath. > I checked on this, and

Re: [ovs-dev] [PATCHv6 13/14] dpif: Minimize memory copy for revalidation.

2014-09-29 Thread Joe Stringer
On 30 September 2014 10:24, Ben Pfaff wrote: > On Fri, Sep 26, 2014 at 09:28:17PM +1200, Joe Stringer wrote: > > One of the limiting factors on the number of flows that can be supported > > in the datapath is the overhead of assembling flow dump messages in the > > datapath. This patch modifies t

Re: [ovs-dev] [PATCHv6 13/14] dpif: Minimize memory copy for revalidation.

2014-09-29 Thread Ben Pfaff
On Fri, Sep 26, 2014 at 09:28:17PM +1200, Joe Stringer wrote: > One of the limiting factors on the number of flows that can be supported > in the datapath is the overhead of assembling flow dump messages in the > datapath. This patch modifies the flow_dump interface to allow > revalidators to skip

[ovs-dev] [PATCHv6 13/14] dpif: Minimize memory copy for revalidation.

2014-09-26 Thread Joe Stringer
One of the limiting factors on the number of flows that can be supported in the datapath is the overhead of assembling flow dump messages in the datapath. This patch modifies the flow_dump interface to allow revalidators to skip dumping the key, mask and actions from the datapath, by making use of