Re: [ovs-dev] [PATCHv4 2/9] dpif-netdev: Group statistics updates in the slow path.

2015-03-30 Thread Ethan Jackson
> Since statistics updates might require locking (in future commits) > grouping them will reduce the locking overhead. Do they actually require locking in future commits or is this speculative? Adding locks for these stats seems like a pretty significant step backwards, have you measured the over

[ovs-dev] [PATCHv4 2/9] dpif-netdev: Group statistics updates in the slow path.

2015-03-27 Thread Daniele Di Proietto
Since statistics updates might require locking (in future commits) grouping them will reduce the locking overhead. Signed-off-by: Daniele Di Proietto --- lib/dpif-netdev.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index