Re: [ovs-dev] [PATCHv4] monitor: Replace monitor_seq with periodic wakeup

2013-12-13 Thread Joe Stringer
I realised that this no longer applies on master. I'll send a rebased version. On 13 December 2013 15:00, Alex Wang wrote: > Hey Ben, > > Could you help review and push it? > > Thanks, > Alex Wang, > > > On Fri, Dec 13, 2013 at 11:29 AM, Alex Wang wrote: >> >> Looks good to me, ran the cfm flap_

Re: [ovs-dev] [PATCHv4] monitor: Replace monitor_seq with periodic wakeup

2013-12-13 Thread Alex Wang
Hey Ben, Could you help review and push it? Thanks, Alex Wang, On Fri, Dec 13, 2013 at 11:29 AM, Alex Wang wrote: > Looks good to me, ran the cfm flap_count test 300 (clang and sparse) times > on my vm > and didn't see the failure any more, > > > On Fri, Dec 13, 2013 at 10:52 AM, Joe Stringer

Re: [ovs-dev] [PATCHv4] monitor: Replace monitor_seq with periodic wakeup

2013-12-13 Thread Alex Wang
Looks good to me, ran the cfm flap_count test 300 (clang and sparse) times on my vm and didn't see the failure any more, On Fri, Dec 13, 2013 at 10:52 AM, Joe Stringer wrote: > Currently, every time a monitoring port is added or reconfigured, the > main thread notifies the monitoring thread to w

[ovs-dev] [PATCHv4] monitor: Replace monitor_seq with periodic wakeup

2013-12-13 Thread Joe Stringer
Currently, every time a monitoring port is added or reconfigured, the main thread notifies the monitoring thread to wake up immediately using monitor_seq. When adding a large number of ports at once, this causes contention as the threads fight over access to the monitor heap---one thread adding new