Thanks. I agree that we should remove IPFIX and sample action support.
I will send v4 for review.
Regards,
William
On Fri, Jul 22, 2016 at 2:38 PM, Ben Pfaff wrote:
> It sounds like snaplen is not very useful in IPFIX. If so, then I'd
> support removing the IPFIX and sample action support for i
It sounds like snaplen is not very useful in IPFIX. If so, then I'd
support removing the IPFIX and sample action support for it.
If you agree, will you send a v4? Otherwise, let me know and I'll apply
v3.
Here's a change I'd like to fold into v3, to better allow for future
extensions. It match
Hi William,
Comments inline.
On 7/12/16, 12:06 PM, "William Tu" wrote:
>Hi Wenyu and Daniel,
>
>Thanks for your feedback.
>
>On Mon, Jul 11, 2016 at 1:50 AM, Wenyu Zhang wrote:
>> Hi William,
>>
>> In your patch, no codes about supporting ³snaplen" in IPFIX included.
>>IPFIX
>> still get the l
Hi Wenyu and Daniel,
Thanks for your feedback.
On Mon, Jul 11, 2016 at 1:50 AM, Wenyu Zhang wrote:
> Hi William,
>
> In your patch, no codes about supporting “snaplen" in IPFIX included. IPFIX
> still get the length of packet as before, whatever the packet is truncated.
> If user put a non-zero
ction?
Wait for Ben's input.
Bests,
Daniel
From: William Tu mailto:u9012...@gmail.com>>
Sent: Sunday, July 10, 2016 9:24:45 PM
To: Daniel Ye
Cc: dev@openvswitch.org<mailto:dev@openvswitch.org>; Ben Pfaff
Subject: Re: [ovs-dev,PATCHv3] ofproto-dp
0, 2016 9:24:45 PM
To: Daniel Ye
Cc: dev@openvswitch.org; Ben Pfaff
Subject: Re: [ovs-dev,PATCHv3] ofproto-dpif-sflow: Add snaplen for sample
action and sFlow.
Hi Daniel,
Thanks for reviewing the patch.
Indeed, the way sFlow sets up the datapath does not require the
OpenFlow sample action, and c
Hi Daniel,
Thanks for reviewing the patch.
Indeed, the way sFlow sets up the datapath does not require the
OpenFlow sample action, and changing OVSDB/compose_sample_action() is
sufficient to program the datapath sample action for current sFlow use
case. So if IPFIX does not use 'snaplen', or there
Hi William,
I saw that you submitted the patch below. It's about adding 'snaplen' for
sample action and sFlow.
https://patchwork.ozlabs.org/patch/645013/
I'm still confused whether sFlow uses the openflow sample action. In my
opinion, sFlow only uses the datapath
sample action, not the sample a
This patch adds a 'snaplen' field in sample action (nx_action_sample2).
Currently, sample action is used by sFlow and IPFIX. For IPFIX, nothing
is changed. For sFlow configuration, the patch translates header=N to
a sample action with snaplen=N, then the snaplen=N translates to trunc(N)
in kernel
