Re: [ovs-dev] [PATCHv3] netdev-provider: Apply batch object to netdev provider.

2016-07-18 Thread William Tu
Thanks for reviewing the patch. I've updated patchv4 at https://patchwork.ozlabs.org/patch/649854/ At netdev_dpdk_send__(), we do need to introduce extra variables, other than that, I've removed the rest of extra variables. Regards, William On Thu, Jul 14, 2016 at 5:34 PM, Daniele Di Proietto w

Re: [ovs-dev] [PATCHv3] netdev-provider: Apply batch object to netdev provider.

2016-07-14 Thread Daniele Di Proietto
Hi William, Thanks for the patch, it makes sense to me! In general I think it would be better to avoid introducing extra local variables like 'pkts' and 'c': I think it would be more readable and the compiler might not always be able to optimize them (I checked the assebly output in a couple of f

Re: [ovs-dev] [PATCHv3] netdev-provider: Apply batch object to netdev provider.

2016-07-03 Thread Ben Pfaff
On Wed, Jun 29, 2016 at 01:53:08PM -0700, William Tu wrote: > Commit 1895cc8dbb64 ("dpif-netdev: create batch object") introduces > batch process functions and 'struct dp_packet_batch' to associate with > batch-level metadata. This patch applies the packet batch object to > the netdev provider int

[ovs-dev] [PATCHv3] netdev-provider: Apply batch object to netdev provider.

2016-06-29 Thread William Tu
Commit 1895cc8dbb64 ("dpif-netdev: create batch object") introduces batch process functions and 'struct dp_packet_batch' to associate with batch-level metadata. This patch applies the packet batch object to the netdev provider interface (dummy, Linux, BSD, and DPDK) so that batch APIs can be used