Re: [ovs-dev] [PATCHv2 5/5] bridge: Only update instant_stats for active protocols

2013-11-21 Thread Joe Stringer
Indeed, I need to be more careful to ensure my implementation patches match my test observations. I'm not fully convinced of the need for a patch like this; My current plan is to tidy up the rest of the series, and do some further experiments before sending a separate follow-up for this. On 20 No

Re: [ovs-dev] [PATCHv2 5/5] bridge: Only update instant_stats for active protocols

2013-11-20 Thread Ben Pfaff
On Thu, Nov 14, 2013 at 03:28:29PM -0800, Joe Stringer wrote: > This patch adds a new field to "struct ofproto" to track which protocols > are active on that bridge. This is updated whenever bfd, cfm, lacp or > stp is enabled. In instant_stats_run(), we query this to determine > whether it is worth

[ovs-dev] [PATCHv2 5/5] bridge: Only update instant_stats for active protocols

2013-11-14 Thread Joe Stringer
This patch adds a new field to "struct ofproto" to track which protocols are active on that bridge. This is updated whenever bfd, cfm, lacp or stp is enabled. In instant_stats_run(), we query this to determine whether it is worthwhile to poll a port's status for each of these protocols. In a test