Re: [ovs-dev] [PATCHv2 4/5] bridge: Only store instant_stats on device changes

2013-11-20 Thread Ben Pfaff
On Mon, Nov 18, 2013 at 03:27:18PM -0800, Joe Stringer wrote: > On 14 November 2013 15:28, Joe Stringer wrote: > > @@ -2529,6 +2538,7 @@ bridge_wait(void) > > > > HMAP_FOR_EACH (br, node, &all_bridges) { > > ofproto_wait(br->ofproto); > > +netdev_seq_wait(br->chan

Re: [ovs-dev] [PATCHv2 4/5] bridge: Only store instant_stats on device changes

2013-11-20 Thread Ben Pfaff
On Thu, Nov 14, 2013 at 03:28:28PM -0800, Joe Stringer wrote: > Previously, we iterated through all interfaces in instant_stats_run(), > grabbing up-to-date information about device status. After assembling > all of this information for all interfaces, we would determine whether > anything changed

Re: [ovs-dev] [PATCHv2 4/5] bridge: Only store instant_stats on device changes

2013-11-18 Thread Joe Stringer
On 14 November 2013 15:28, Joe Stringer wrote: > @@ -2529,6 +2538,7 @@ bridge_wait(void) > > HMAP_FOR_EACH (br, node, &all_bridges) { > ofproto_wait(br->ofproto); > +netdev_seq_wait(br->change_seq); > } > poll_timer_wait_until(iface_stats_timer);

[ovs-dev] [PATCHv2 4/5] bridge: Only store instant_stats on device changes

2013-11-14 Thread Joe Stringer
Previously, we iterated through all interfaces in instant_stats_run(), grabbing up-to-date information about device status. After assembling all of this information for all interfaces, we would determine whether anything changed and only send an update to ovsdb-server if something changed. This pa