Re: [ovs-dev] [PATCHv2 2/2] datapath: Cache netlink flow key, mask on flow_put.

2014-07-15 Thread Joe Stringer
On 16 July 2014 12:15, Joe Stringer wrote: > > + ovs_nla_copy_flow(a[OVS_FLOW_ATTR_KEY], a[OVS_FLOW_ATTR_MASK], > + new_flow->nl_match_cache); I realised that this needs to be wrapped in a NULL check for "new_flow->nl_match_cache", in case the skb_alloc() fails. ___

[ovs-dev] [PATCHv2 2/2] datapath: Cache netlink flow key, mask on flow_put.

2014-07-15 Thread Joe Stringer
Converting the flow key and mask back into netlink format during flow dump is fairly expensive. By caching the userspace-provided versions of these during flow setup, and copying the memory directly during flow dump, we are able to support up to 33% more flows in the datapath. Previous top-5 perf