Re: [ovs-dev] [PATCHv2 1/2] ofproto-dpif-xlate: Fix bitwise ops on ct_mark.

2016-04-04 Thread Joe Stringer
On 4 April 2016 at 11:20, Joe Stringer wrote: > On 30 March 2016 at 19:55, Ben Pfaff wrote: >> On Thu, Mar 31, 2016 at 12:21:13AM +1300, Joe Stringer wrote: >>> Using the action ct(commit,set_field:0x1/0x1->ct_mark), ie, specifying a >>> mask, would previously overwrite the entire ct_mark field r

Re: [ovs-dev] [PATCHv2 1/2] ofproto-dpif-xlate: Fix bitwise ops on ct_mark.

2016-04-04 Thread Joe Stringer
On 30 March 2016 at 19:55, Ben Pfaff wrote: > On Thu, Mar 31, 2016 at 12:21:13AM +1300, Joe Stringer wrote: >> Using the action ct(commit,set_field:0x1/0x1->ct_mark), ie, specifying a >> mask, would previously overwrite the entire ct_mark field rather than >> modifying only the specified bits. Fix

Re: [ovs-dev] [PATCHv2 1/2] ofproto-dpif-xlate: Fix bitwise ops on ct_mark.

2016-03-30 Thread Ben Pfaff
On Thu, Mar 31, 2016 at 12:21:13AM +1300, Joe Stringer wrote: > Using the action ct(commit,set_field:0x1/0x1->ct_mark), ie, specifying a > mask, would previously overwrite the entire ct_mark field rather than > modifying only the specified bits. Fix the issue. > > Fixes: 8e53fe8cf7a1 ("Add connect

[ovs-dev] [PATCHv2 1/2] ofproto-dpif-xlate: Fix bitwise ops on ct_mark.

2016-03-30 Thread Joe Stringer
Using the action ct(commit,set_field:0x1/0x1->ct_mark), ie, specifying a mask, would previously overwrite the entire ct_mark field rather than modifying only the specified bits. Fix the issue. Fixes: 8e53fe8cf7a1 ("Add connection tracking mark support.") Signed-off-by: Joe Stringer --- v2: Remove