Re: [ovs-dev] [PATCHv2 1/2] datapath: Move key_attr_size() to flow_netlink.h.

2014-08-14 Thread Joe Stringer
On 14 August 2014 10:22, Pravin Shelar wrote: > > Can you move this definition next to ovs_key_lens definition. > > otherwise looks good. > Acked-by: Pravin B Shelar Thanks, I made this change and pushed this to master. ___ dev mailing list dev@openvs

Re: [ovs-dev] [PATCHv2 1/2] datapath: Move key_attr_size() to flow_netlink.h.

2014-08-13 Thread Pravin Shelar
On Tue, Jul 15, 2014 at 5:15 PM, Joe Stringer wrote: > Signed-off-by: Joe Stringer > --- > v2: First post. > > Side comment: OVS_KEY_ATTR_ETHERTYPE appears twice in this list. I guess > it's not harmful to reserve a bit of extra space, but does anyone know > why it's there twice? > --- > datapat

Re: [ovs-dev] [PATCHv2 1/2] datapath: Move key_attr_size() to flow_netlink.h.

2014-07-20 Thread Joe Stringer
On 16 July 2014 12:15, Joe Stringer wrote: > Signed-off-by: Joe Stringer > This patch was previously required for the series "datapath: Cache netlink flow key, mask on flow_put.", but is no longer required for newer versions of that, as I've changed the approach. If this seems like a reasonabl

Re: [ovs-dev] [PATCHv2 1/2] datapath: Move key_attr_size() to flow_netlink.h.

2014-07-16 Thread Ben Pfaff
On Wed, Jul 16, 2014 at 12:15:40PM +1200, Joe Stringer wrote: > Side comment: OVS_KEY_ATTR_ETHERTYPE appears twice in this list. I guess > it's not harmful to reserve a bit of extra space, but does anyone know > why it's there twice? It's because OVS_KEY_ATTR_ETHERTYPE appears twice if there's a V

[ovs-dev] [PATCHv2 1/2] datapath: Move key_attr_size() to flow_netlink.h.

2014-07-15 Thread Joe Stringer
Signed-off-by: Joe Stringer --- v2: First post. Side comment: OVS_KEY_ATTR_ETHERTYPE appears twice in this list. I guess it's not harmful to reserve a bit of extra space, but does anyone know why it's there twice? --- datapath/datapath.c | 37 +++-- datapath