Pushed to master and branch-2.1.
On 24 April 2014 11:06, Joe Stringer wrote:
> On 24 April 2014 04:56, Alex Wang wrote:
>
>>
>> On Tue, Apr 22, 2014 at 10:24 PM, Alex Wang wrote:
>>
>>> diff --git a/ofproto/ofproto-dpif-upcall.c
b/ofproto/ofproto-dpif-upcall.c
index 416cfdc..906bf17
On 24 April 2014 04:56, Alex Wang wrote:
>
> On Tue, Apr 22, 2014 at 10:24 PM, Alex Wang wrote:
>
>> diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
>>> index 416cfdc..906bf17 100644
>>> --- a/ofproto/ofproto-dpif-upcall.c
>>> +++ b/ofproto/ofproto-dpif-upcall.c
>>> @@
On Tue, Apr 22, 2014 at 10:24 PM, Alex Wang wrote:
> diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
>> index 416cfdc..906bf17 100644
>> --- a/ofproto/ofproto-dpif-upcall.c
>> +++ b/ofproto/ofproto-dpif-upcall.c
>> @@ -45,6 +45,8 @@
>>
>> VLOG_DEFINE_THIS_MODULE(ofprot
Hey Joe,
Great to see this patch, one comment below:
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
> index 416cfdc..906bf17 100644
> --- a/ofproto/ofproto-dpif-upcall.c
> +++ b/ofproto/ofproto-dpif-upcall.c
> @@ -45,6 +45,8 @@
>
> VLOG_DEFINE_THIS_MODULE(ofproto_dpi
When the datapath flow table is modified while a flow dump operation is
in progress, it is possible for the same flow to be dumped twice. In
such cases, revalidators may perform redundant work, or attempt to
delete the same flow twice.
This was causing intermittent testsuite failures for test #670
