Re: [ovs-dev] [PATCHv2] ofproto-dpif-sflow: Add snaplen for sample action and sFlow.

2016-07-05 Thread William Tu
Hi Ben, Thanks, I've fixed it and submitted new version. Regards, William On Fri, Jul 1, 2016 at 9:28 PM, Ben Pfaff wrote: > On Fri, Jul 01, 2016 at 12:43:02PM -0700, William Tu wrote: >> This patch adds a 'snaplen' field in sample action (nx_action_sample2). >> Currently, sample action is use

Re: [ovs-dev] [PATCHv2] ofproto-dpif-sflow: Add snaplen for sample action and sFlow.

2016-07-01 Thread Ben Pfaff
On Fri, Jul 01, 2016 at 12:43:02PM -0700, William Tu wrote: > This patch adds a 'snaplen' field in sample action (nx_action_sample2). > Currently, sample action is used by sFlow and IPFIX. For IPFIX, nothing > is changed. For sFlow configuration, the patch translates header=N to > a sample action

[ovs-dev] [PATCHv2] ofproto-dpif-sflow: Add snaplen for sample action and sFlow.

2016-07-01 Thread William Tu
This patch adds a 'snaplen' field in sample action (nx_action_sample2). Currently, sample action is used by sFlow and IPFIX. For IPFIX, nothing is changed. For sFlow configuration, the patch translates header=N to a sample action with snaplen=N, then the snaplen=N translates to trunc(N) in kernel