Re: [ovs-dev] [PATCHv2] ofproto-dpif: Always un-wildcard fields that are being set.

2013-08-03 Thread Justin Pettit
On Aug 2, 2013, at 11:13 PM, Ben Pfaff wrote: > On Fri, Aug 02, 2013 at 10:57:53PM -0700, Justin Pettit wrote: >> The ODP library has an optimization to not set a header if the field was >> not changed, regardless of whether an action to set the field was >> present. That library is also respon

Re: [ovs-dev] [PATCHv2] ofproto-dpif: Always un-wildcard fields that are being set.

2013-08-02 Thread Ben Pfaff
On Fri, Aug 02, 2013 at 11:24:58PM -0700, Jesse Gross wrote: > On Fri, Aug 2, 2013 at 11:13 PM, Ben Pfaff wrote: > > On Fri, Aug 02, 2013 at 10:57:53PM -0700, Justin Pettit wrote: > >> The ODP library has an optimization to not set a header if the field was > >> not changed, regardless of whether

Re: [ovs-dev] [PATCHv2] ofproto-dpif: Always un-wildcard fields that are being set.

2013-08-02 Thread Jesse Gross
On Fri, Aug 2, 2013 at 11:13 PM, Ben Pfaff wrote: > On Fri, Aug 02, 2013 at 10:57:53PM -0700, Justin Pettit wrote: >> The ODP library has an optimization to not set a header if the field was >> not changed, regardless of whether an action to set the field was >> present. That library is also resp

Re: [ovs-dev] [PATCHv2] ofproto-dpif: Always un-wildcard fields that are being set.

2013-08-02 Thread Ben Pfaff
On Fri, Aug 02, 2013 at 10:57:53PM -0700, Justin Pettit wrote: > The ODP library has an optimization to not set a header if the field was > not changed, regardless of whether an action to set the field was > present. That library is also responsible for un-wildcarding fields > that are bieng modif

[ovs-dev] [PATCHv2] ofproto-dpif: Always un-wildcard fields that are being set.

2013-08-02 Thread Justin Pettit
The ODP library has an optimization to not set a header if the field was not changed, regardless of whether an action to set the field was present. That library is also responsible for un-wildcarding fields that are bieng modified. This leads to a problem where a packet matches a flow that update