Re: [ovs-dev] [PATCHv13] ofproto-dpif-upcall: Remove the flow_dumper thread.

2014-04-25 Thread Alex Wang
Found the bug, i introduced it, so sorry, On Fri, Apr 25, 2014 at 9:45 AM, Gurucharan Shetty wrote: > Alex wanted the backtrace: > at ../nptl/sysdeps/unix/sysv/linux/raise.c:64 > #1 0x76d13bab in __GI_abort () at abort.c:91 > #2 0x004f08b0 in ovs_abort_valist (err_no=22, >

Re: [ovs-dev] [PATCHv13] ofproto-dpif-upcall: Remove the flow_dumper thread.

2014-04-25 Thread Gurucharan Shetty
Alex wanted the backtrace: at ../nptl/sysdeps/unix/sysv/linux/raise.c:64 #1 0x76d13bab in __GI_abort () at abort.c:91 #2 0x004f08b0 in ovs_abort_valist (err_no=22, format=0x55714f "%s failed", args=0x7fffdf58) at lib/util.c:306 #3 0x004f0883 in ovs_abort (err_

Re: [ovs-dev] [PATCHv13] ofproto-dpif-upcall: Remove the flow_dumper thread.

2014-04-25 Thread Gurucharan Shetty
With this patch, ovs-vswitchd now crashes with the following error during upgrades. ovs-vswitchd: pthread_barrier_init failed (Invalid argument) ovs-vswitchd: fork child died before signaling startup (killed (Aborted), core dumped) Note that this happens when ovs-vswitchd is started with: other_c

Re: [ovs-dev] [PATCHv13] ofproto-dpif-upcall: Remove the flow_dumper thread.

2014-04-23 Thread Ethan Jackson
W00t, nice to see this in. Ethan On Wed, Apr 23, 2014 at 9:32 PM, Joe Stringer wrote: > Thanks, I tidied up the comments, added threadsafety annotations for xcache > and pushed. > > > On 24 April 2014 06:38, Ben Pfaff wrote: >> >> On Tue, Apr 22, 2014 at 04:54:24PM +1200, Joe Stringer wrote: >>

Re: [ovs-dev] [PATCHv13] ofproto-dpif-upcall: Remove the flow_dumper thread.

2014-04-23 Thread Joe Stringer
Thanks, I tidied up the comments, added threadsafety annotations for xcache and pushed. On 24 April 2014 06:38, Ben Pfaff wrote: > On Tue, Apr 22, 2014 at 04:54:24PM +1200, Joe Stringer wrote: > > From: Ethan Jackson > > > > Previously, we had a separate flow_dumper thread that fetched flows f

Re: [ovs-dev] [PATCHv13] ofproto-dpif-upcall: Remove the flow_dumper thread.

2014-04-23 Thread Ben Pfaff
On Tue, Apr 22, 2014 at 04:54:24PM +1200, Joe Stringer wrote: > From: Ethan Jackson > > Previously, we had a separate flow_dumper thread that fetched flows from > the datapath to distribute to revalidator threads. This patch takes the > logic for dumping and pushes it into the revalidator threads

[ovs-dev] [PATCHv13] ofproto-dpif-upcall: Remove the flow_dumper thread.

2014-04-21 Thread Joe Stringer
From: Ethan Jackson Previously, we had a separate flow_dumper thread that fetched flows from the datapath to distribute to revalidator threads. This patch takes the logic for dumping and pushes it into the revalidator threads, resulting in simpler code with similar performance to the current code