Re: [ovs-dev] [PATCHv11 net-next 2/2] openvswitch: Add support for unique flow IDs.

2014-12-10 Thread Pravin Shelar
On Wed, Dec 10, 2014 at 10:15 AM, Joe Stringer wrote: > On 9 December 2014 at 22:11, Pravin Shelar wrote: >> On Tue, Dec 9, 2014 at 4:25 PM, Joe Stringer wrote: >>> On 9 December 2014 at 10:32, Pravin Shelar wrote: On Tue, Dec 2, 2014 at 6:56 PM, Joe Stringer wrote: > @@ -424,10

Re: [ovs-dev] [PATCHv11 net-next 2/2] openvswitch: Add support for unique flow IDs.

2014-12-10 Thread Joe Stringer
On 9 December 2014 at 22:11, Pravin Shelar wrote: > On Tue, Dec 9, 2014 at 4:25 PM, Joe Stringer wrote: >> On 9 December 2014 at 10:32, Pravin Shelar wrote: >>> On Tue, Dec 2, 2014 at 6:56 PM, Joe Stringer wrote: @@ -424,10 +475,9 @@ static struct sw_flow *masked_flow_lookup(struct t

Re: [ovs-dev] [PATCHv11 net-next 2/2] openvswitch: Add support for unique flow IDs.

2014-12-09 Thread Pravin Shelar
On Tue, Dec 9, 2014 at 4:25 PM, Joe Stringer wrote: > On 9 December 2014 at 10:32, Pravin Shelar wrote: >> On Tue, Dec 2, 2014 at 6:56 PM, Joe Stringer wrote: >>> @@ -662,11 +664,18 @@ static void get_dp_stats(const struct datapath *dp, >>> struct ovs_dp_stats *stats, >>> } >>> } >>>

Re: [ovs-dev] [PATCHv11 net-next 2/2] openvswitch: Add support for unique flow IDs.

2014-12-09 Thread Joe Stringer
On 9 December 2014 at 10:32, Pravin Shelar wrote: > On Tue, Dec 2, 2014 at 6:56 PM, Joe Stringer wrote: >> @@ -662,11 +664,18 @@ static void get_dp_stats(const struct datapath *dp, >> struct ovs_dp_stats *stats, >> } >> } >> >> -static size_t ovs_flow_cmd_msg_size(const struct sw_flow_a

Re: [ovs-dev] [PATCHv11 net-next 2/2] openvswitch: Add support for unique flow IDs.

2014-12-09 Thread David Miller
Please do not quote an entire patch just to add some simple feedback or signoff/ack. That means someone has to scroll past the entire patch in patchwork or the mailing list archives, unnecessarily. This is one of my largest pet peeves, please do not do this. Thanks.

Re: [ovs-dev] [PATCHv11 net-next 2/2] openvswitch: Add support for unique flow IDs.

2014-12-09 Thread Pravin Shelar
On Tue, Dec 2, 2014 at 6:56 PM, Joe Stringer wrote: > Previously, flows were manipulated by userspace specifying a full, > unmasked flow key. This adds significant burden onto flow > serialization/deserialization, particularly when dumping flows. > > This patch adds an alternative way to refer to

Re: [ovs-dev] [PATCHv11 net-next 2/2] openvswitch: Add support for unique flow IDs.

2014-12-03 Thread Joe Stringer
On 3 December 2014 at 11:45, Pravin Shelar wrote: > On Wed, Dec 3, 2014 at 10:47 AM, Joe Stringer wrote: >> I forgot to mention that this is the first post based against net-next. >> >> On 2 December 2014 at 18:56, Joe Stringer wrote: >>> >>> diff --git a/net/openvswitch/flow.h b/n

Re: [ovs-dev] [PATCHv11 net-next 2/2] openvswitch: Add support for unique flow IDs.

2014-12-03 Thread Pravin Shelar
On Wed, Dec 3, 2014 at 10:47 AM, Joe Stringer wrote: > I forgot to mention that this is the first post based against net-next. > > On 2 December 2014 at 18:56, Joe Stringer wrote: >> >> diff --git a/net/openvswitch/flow.h b/net/openvswitch/flow.h >> index a8b30f3..7f31dbf 100644 >>

Re: [ovs-dev] [PATCHv11 net-next 2/2] openvswitch: Add support for unique flow IDs.

2014-12-03 Thread Joe Stringer
I forgot to mention that this is the first post based against net-next. On 2 December 2014 at 18:56, Joe Stringer wrote: > > diff --git a/net/openvswitch/flow.h b/net/openvswitch/flow.h > index a8b30f3..7f31dbf 100644 > --- a/net/openvswitch/flow.h > +++ b/net/openvswitch/flow.h > @

[ovs-dev] [PATCHv11 net-next 2/2] openvswitch: Add support for unique flow IDs.

2014-12-02 Thread Joe Stringer
Previously, flows were manipulated by userspace specifying a full, unmasked flow key. This adds significant burden onto flow serialization/deserialization, particularly when dumping flows. This patch adds an alternative way to refer to flows using a variable-length "unique flow identifier" (UFID).